[
https://issues.apache.org/jira/browse/HIVE-25482?focusedWorklogId=643485&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-643485
]
ASF GitHub Bot logged work on HIVE-25482:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/21 14:10
Start Date: 30/Aug/21 14:10
Worklog Time Spent: 10m
Work Description: avpash43 commented on a change in pull request #2610:
URL: https://github.com/apache/hive/pull/2610#discussion_r698521908
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
##########
@@ -602,6 +602,13 @@ public static ConfVars getMetaConf(String name) {
CONNECTION_USER_NAME("javax.jdo.option.ConnectionUserName",
"javax.jdo.option.ConnectionUserName", "APP",
"Username to use against metastore database"),
+
CONNECTION_LEAK_DETECTION_THRESHOLD("javax.jdo.option.ConnectionLeakDetectionThreshold",
Review comment:
"Can you refer to MetaStoreConf?" - I didn't catch you. What do you
mean? Just create constant or what?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 643485)
Time Spent: 50m (was: 40m)
> Add option to enable connectionLeak detection for Hikari datasource
> -------------------------------------------------------------------
>
> Key: HIVE-25482
> URL: https://issues.apache.org/jira/browse/HIVE-25482
> Project: Hive
> Issue Type: Improvement
> Reporter: Rajesh Balamohan
> Assignee: Aleksandr Pashkovskii
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> There are corner cases where we observed connection leaks to DB.
>
> It will be good to add an option to provide connection leak timeout parameter
> in HikariCPDataSourceProvider.
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java#L69]
> e.g following should help Hikari to warn about connection leak, when a
> connection is not returned to the pool for 1 hour.
> {noformat}
> config.setLeakDetectionThreshold(3600*1000); {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
