[
https://issues.apache.org/jira/browse/HIVE-23633?focusedWorklogId=646782&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646782
]
ASF GitHub Bot logged work on HIVE-23633:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/21 08:20
Start Date: 06/Sep/21 08:20
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #2344:
URL: https://github.com/apache/hive/pull/2344#discussion_r702701009
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/QueryWrapper.java
##########
@@ -0,0 +1,430 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.metastore;
+
+import javax.jdo.Extent;
+import javax.jdo.FetchPlan;
+import javax.jdo.PersistenceManager;
+import javax.jdo.Query;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A wrapper around the Query object to the caller and let the caller release
Review comment:
Thank you for the review!
The method `close()` of `Query` throws exception, we should catch the
exception explicitly when using use with try-with-resources:
```java
/**
* Don't use this method directly; use <code>closeAll()</code> instead.
It is intended for use with try-with-resources.
* @throws Exception if this resource cannot be closed
*/
void close() throws Exception;
```
The exception would mix with the exception thrown in the `ObjectStore` or
`MetaStoreDirectSql`, make it uneasy to handle on the caller, as I do not
want to break the specified exceptions of the original method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 646782)
Time Spent: 10h 40m (was: 10.5h)
> Metastore some JDO query objects do not close properly
> ------------------------------------------------------
>
> Key: HIVE-23633
> URL: https://issues.apache.org/jira/browse/HIVE-23633
> Project: Hive
> Issue Type: Bug
> Reporter: Zhihua Deng
> Assignee: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-23633.01.patch
>
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
> After patched [HIVE-10895|https://issues.apache.org/jira/browse/HIVE-10895],
> The metastore still has seen a memory leak on db resources: many
> StatementImpls left unclosed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
