[ 
https://issues.apache.org/jira/browse/HIVE-25501?focusedWorklogId=647250&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-647250
 ]

ASF GitHub Bot logged work on HIVE-25501:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Sep/21 09:11
            Start Date: 07/Sep/21 09:11
    Worklog Time Spent: 10m 
      Work Description: abstractdog commented on a change in pull request #2620:
URL: https://github.com/apache/hive/pull/2620#discussion_r703329281



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java
##########
@@ -573,31 +665,23 @@ public PartitionDesc read(Kryo kryo, Input input, Class<? 
extends PartitionDesc>
    * @param out  The stream to write to.
    */
   public static void serializePlan(Object plan, OutputStream out) {
-    serializePlan(plan, out, false);
-  }
-
-  public static void serializePlan(Kryo kryo, Object plan, OutputStream out) {
-    serializePlan(kryo, plan, out, false);
+    serializePlan(plan, out, null);
   }
 
-  private static void serializePlan(Object plan, OutputStream out, boolean 
cloningPlan) {
-    Kryo kryo = borrowKryo();
+  private static void serializePlan(Object plan, OutputStream out, 
Configuration configuration) {

Review comment:
       yeah, I've just created a new test class, TestSerializationUtilities




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 647250)
    Time Spent: 0.5h  (was: 20m)

> Provide a filter for removing useless properties from PartitionDesc objects 
> before MapWork serialization
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-25501
>                 URL: https://issues.apache.org/jira/browse/HIVE-25501
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This is due to performance considerations. When a large amount of partitions 
> is present in MapWork, serializing useless properties (coming from metastore 
> as a partititon metadata) could become a bottleneck, which can even lead to 
> OOM in Tez AM if the dag plan becomes large.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to