[
https://issues.apache.org/jira/browse/HIVE-25330?focusedWorklogId=648445&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648445
]
ASF GitHub Bot logged work on HIVE-25330:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/21 07:53
Start Date: 09/Sep/21 07:53
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #2516:
URL: https://github.com/apache/hive/pull/2516#discussion_r705078639
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/util/Retryable.java
##########
@@ -166,6 +169,25 @@ public synchronized Builder withRetryOnExceptionList(final
List<Class<? extends
return this;
}
+ public synchronized Builder withFailOnParentException(final Class<?
extends Exception> exceptionClass) {
+ if (exceptionClass != null &&
+ runnable.failOnParentExceptions.stream().noneMatch(k ->
exceptionClass.equals(k))) {
+ runnable.failOnParentExceptions.add(exceptionClass);
+ }
+ return this;
+ }
+
+ public synchronized Builder withFailOnParentExceptionList(final
List<Class<?
+ extends Exception>> exceptionClassList) {
+ for (final Class<? extends Exception> exceptionClass :
exceptionClassList) {
+ if (exceptionClass != null &&
+ runnable.failOnParentExceptions.stream().noneMatch(k ->
exceptionClass.equals(k))) {
+ runnable.failOnParentExceptions.add(exceptionClass);
+ }
Review comment:
Rather than checking for a unique entry ourselves, can we not use a set
instead of a list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 648445)
Time Spent: 50m (was: 40m)
> Make FS calls in CopyUtils retryable
> ------------------------------------
>
> Key: HIVE-25330
> URL: https://issues.apache.org/jira/browse/HIVE-25330
> Project: Hive
> Issue Type: Improvement
> Reporter: Pravin Sinha
> Assignee: Haymant Mangla
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
