[ https://issues.apache.org/jira/browse/HIVE-25346?focusedWorklogId=649899&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649899 ]
ASF GitHub Bot logged work on HIVE-25346: ----------------------------------------- Author: ASF GitHub Bot Created on: 13/Sep/21 09:55 Start Date: 13/Sep/21 09:55 Worklog Time Spent: 10m Work Description: deniskuzZ commented on a change in pull request #2547: URL: https://github.com/apache/hive/pull/2547#discussion_r707182717 ########## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java ########## @@ -531,7 +531,7 @@ public void cleanTxnToWriteIdTable() throws MetaException { String s = "SELECT MIN(\"RES\".\"ID\") AS \"ID\" FROM (" + "SELECT MAX(\"TXN_ID\") + 1 AS \"ID\" FROM \"TXNS\" " + "UNION " + - "SELECT MIN(\"WS_COMMIT_ID\") AS \"ID\" FROM \"WRITE_SET\" " + + "SELECT MIN(\"WS_TXNID\") AS \"ID\" FROM \"WRITE_SET\" " + Review comment: ````With the new change we are only keeping the WRITE_SET based on the transactionId when the actual write was committed (not when the actual write was started), as the previous queries should not read the non-committed folder/data anyway```` that leads to the violation of the SNAPSHOT isolation, see `testUpdateSnapshotIsolation test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 649899) Time Spent: 6.5h (was: 6h 20m) > cleanTxnToWriteIdTable breaks SNAPSHOT isolation > ------------------------------------------------ > > Key: HIVE-25346 > URL: https://issues.apache.org/jira/browse/HIVE-25346 > Project: Hive > Issue Type: Bug > Reporter: Zoltan Chovan > Assignee: Zoltan Chovan > Priority: Major > Labels: pull-request-available > Time Spent: 6.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)