[ https://issues.apache.org/jira/browse/HIVE-25527?focusedWorklogId=651134&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-651134 ]
ASF GitHub Bot logged work on HIVE-25527: ----------------------------------------- Author: ASF GitHub Bot Created on: 15/Sep/21 14:52 Start Date: 15/Sep/21 14:52 Worklog Time Spent: 10m Work Description: pgaref commented on a change in pull request #2645: URL: https://github.com/apache/hive/pull/2645#discussion_r709269471 ########## File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java ########## @@ -1447,8 +1447,14 @@ private SelectHostResult selectHost(TaskInfo request, Map<String, List<NodeInfo> if (request.shouldForceLocality()) { requestedHostsWillBecomeAvailable = true; } else { - LlapServiceInstance inst = activeInstances.getByHost(host).stream().findFirst().get(); - NodeInfo nodeInfo = instanceToNodeMap.get(inst.getWorkerIdentity()); + Set<LlapServiceInstance> instanceTypes = activeInstances.getByHost(host); Review comment: Looks like this may happen when a node goes down between getResourceAvailability() call until selectHost() is triggered. Following the previous logic I believe the check should be performed at the same level as: ```availableHostMap.containsKey(host)``` as these type of requests should not be waiting for requestedHostsWillBecomeAvailable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 651134) Time Spent: 20m (was: 10m) > LLAP Scheduler task exits with fatal error if the executor node is down. > ------------------------------------------------------------------------ > > Key: HIVE-25527 > URL: https://issues.apache.org/jira/browse/HIVE-25527 > Project: Hive > Issue Type: Bug > Components: HiveServer2 > Reporter: mahesh kumar behera > Assignee: mahesh kumar behera > Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > In case the executor host has gone down, activeInstances will be updated with > null. So we need to check for empty/null values before accessing it. -- This message was sent by Atlassian Jira (v8.3.4#803005)