[
https://issues.apache.org/jira/browse/HIVE-25317?focusedWorklogId=651928&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-651928
]
ASF GitHub Bot logged work on HIVE-25317:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Sep/21 18:23
Start Date: 16/Sep/21 18:23
Worklog Time Spent: 10m
Work Description: sunchao commented on a change in pull request #2459:
URL: https://github.com/apache/hive/pull/2459#discussion_r710369202
##########
File path: llap-server/pom.xml
##########
@@ -38,6 +38,7 @@
<groupId>org.apache.hive</groupId>
<artifactId>hive-exec</artifactId>
<version>${project.version}</version>
+ <classifier>core</classifier>
Review comment:
@kgyrtkirk Guava is shaded in branch-2.3 via
https://issues.apache.org/jira/browse/HIVE-23980. The issue is, in order for
Spark to use shaded `hive-exec`, Hive will need to relocate more classes and at
the same time making sure it won't break other modules (for instance, if the
shaded class appears in certain API and another module imported the unshaded
version of the class by itself).
Currently we've abandoned this approach and decided to shade the
`hive-exec-core` within Spark itself, following similar approach in Trino (see
https://github.com/trinodb/trino-hive-apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 651928)
Time Spent: 3.5h (was: 3h 20m)
> Relocate dependencies in shaded hive-exec module
> ------------------------------------------------
>
> Key: HIVE-25317
> URL: https://issues.apache.org/jira/browse/HIVE-25317
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 2.3.8
> Reporter: L. C. Hsieh
> Assignee: L. C. Hsieh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> When we want to use shaded version of hive-exec (i.e., w/o classifier), more
> dependencies conflict with Spark. We need to relocate these dependencies too.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
