[
https://issues.apache.org/jira/browse/HIVE-25534?focusedWorklogId=652789&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652789
]
ASF GitHub Bot logged work on HIVE-25534:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/21 06:18
Start Date: 20/Sep/21 06:18
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #2650:
URL: https://github.com/apache/hive/pull/2650#discussion_r711889438
##########
File path:
shims/0.23/src/main/test/org/apache/hadoop/hive/shims/TestHadoop23Shims.java
##########
@@ -94,6 +97,26 @@ public void testConstructDistCpParams() {
}
+ @Test
Review comment:
Also add test for other non supported FS.
##########
File path:
shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java
##########
@@ -277,6 +277,16 @@ private boolean isFairScheduler (Configuration conf) {
equalsIgnoreCase(conf.get(YarnConfiguration.RM_SCHEDULER));
}
+ private boolean checkFileSystemXAttrSupport(FileSystem fs) {
+ try {
+ fs.getXAttrs(new Path(Path.SEPARATOR));
+ } catch (Exception e) {
+ LOG.warn("XAttr won't be preserved since it is not supported for file
system: " + fs.getUri());
+ return false;
Review comment:
Any exception can't be concluded this way. It could give you wrong
results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 652789)
Time Spent: 40m (was: 0.5h)
> Error when executing DistCp on file system not supporting XAttrs
> ----------------------------------------------------------------
>
> Key: HIVE-25534
> URL: https://issues.apache.org/jira/browse/HIVE-25534
> Project: Hive
> Issue Type: Bug
> Reporter: Haymant Mangla
> Assignee: Haymant Mangla
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Remove the preserve xattr while calling distcp.
> {code:java}
> 2021-08-23 10:06:18,485 ERROR org.apache.hadoop.tools.DistCp:
> [HiveServer2-Background-Pool: Thread-73]: XAttrs not supported on at least
> one file system:
> org.apache.hadoop.tools.CopyListing$XAttrsNotSupportedException: XAttrs not
> supported for file system: s3a://hmangla1-dev
> at
> org.apache.hadoop.tools.util.DistCpUtils.checkFileSystemXAttrSupport(DistCpUtils.java:513)
> ~[hadoop-distcp-3.1.1.7.1.6.0-297.jar:?]
> at org.apache.hadoop.tools.DistCp.configureOutputFormat(DistCp.java:337)
> ~[hadoop-distcp-3.1.1.7.1.6.0-297.jar:?]
> at org.apache.hadoop.tools.DistCp.createJob(DistCp.java:304)
> ~[hadoop-distcp-3.1.1.7.1.6.0-297.jar:?]
> at org.apache.hadoop.tools.DistCp.createAndSubmitJob(DistCp.java:214)
> ~[hadoop-distcp-3.1.1.7.1.6.0-297.jar:?]
> at org.apache.hadoop.tools.DistCp.execute(DistCp.java:193)
> ~[hadoop-distcp-3.1.1.7.1.6.0-297.jar:?]{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
