[
https://issues.apache.org/jira/browse/HIVE-25587?focusedWorklogId=659261&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-659261
]
ASF GitHub Bot logged work on HIVE-25587:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/21 18:03
Start Date: 02/Oct/21 18:03
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2696:
URL: https://github.com/apache/hive/pull/2696#discussion_r720709682
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -234,16 +240,16 @@ public void
preAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable, E
icebergTable = IcebergTableUtil.getTable(conf, catalogProperties);
} catch (NoSuchTableException nte) {
context.getProperties().put(MIGRATE_HIVE_TO_ICEBERG, "true");
- // If the iceberg table does not exist, and the hms table is external
and not temporary and not acid
- // we will create it in commitAlterTable
- StorageDescriptor sd = hmsTable.getSd();
- canMigrateHiveTable = MetaStoreUtils.isExternalTable(hmsTable) &&
!hmsTable.isTemporary() &&
- !AcidUtils.isTransactionalTable(hmsTable);
- if (!canMigrateHiveTable) {
- throw new MetaException("Converting non-external, temporary or
transactional hive table to iceberg " +
- "table is not allowed.");
- }
+ // If the iceberg table does not exist, and the hms table is:
+ // - external
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 659261)
Time Spent: 0.5h (was: 20m)
> Disable Iceberg table migration for unsupported source file formats
> -------------------------------------------------------------------
>
> Key: HIVE-25587
> URL: https://issues.apache.org/jira/browse/HIVE-25587
> Project: Hive
> Issue Type: Improvement
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, we only support migrating ORC, Parquet and Avro tables to Iceberg.
> However, there is no check in the code to fail early for other formats (e.g.
> text, json, rcfile), which can lead to wasted effort at best, and leaving the
> source table unusable at worst. Therefore, we should check the source format
> early and shortcircuit for unsupported types.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
