[
https://issues.apache.org/jira/browse/HIVE-25011?focusedWorklogId=660204&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-660204
]
ASF GitHub Bot logged work on HIVE-25011:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/21 10:25
Start Date: 05/Oct/21 10:25
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #2660:
URL: https://github.com/apache/hive/pull/2660#discussion_r722102438
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -184,19 +183,17 @@ public boolean accept(Path path) {
public static final int MAX_STATEMENTS_PER_TXN = 10000;
public static final Pattern LEGACY_BUCKET_DIGIT_PATTERN =
Pattern.compile("^[0-9]{6}");
public static final Pattern BUCKET_PATTERN =
Pattern.compile("bucket_([0-9]+)(_[0-9]+)?$");
- private static final Set<Integer> READ_TXN_TOKENS = new HashSet<Integer>();
+ private static final Set<Integer> READ_TXN_TOKENS = new HashSet<>();
private static Cache<String, DirInfoValue> dirCache;
private static AtomicBoolean dirCacheInited = new AtomicBoolean();
static {
READ_TXN_TOKENS.addAll(Arrays.asList(
- HiveParser.TOK_DESCDATABASE,
- HiveParser.TOK_DESCTABLE,
- HiveParser.TOK_SHOWTABLES,
- HiveParser.TOK_SHOW_TABLESTATUS,
- HiveParser.TOK_SHOW_TBLPROPERTIES,
Review comment:
Because those don't even need a txn. I would have removed all of the
operations (EXPLAIN, DESC), however, that cause number of old tests to fail
that validate txnIds. I'll handle them separately in diff JIRAs 1-by-1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 660204)
Time Spent: 1h 20m (was: 1h 10m)
> Concurrency: Do not acquire locks for EXPLAIN and initiate implicit
> transaction for SHOW commands
> -------------------------------------------------------------------------------------------------
>
> Key: HIVE-25011
> URL: https://issues.apache.org/jira/browse/HIVE-25011
> Project: Hive
> Issue Type: Improvement
> Components: Locking, Transactions
> Affects Versions: 4.0.0
> Reporter: Gopal Vijayaraghavan
> Assignee: Gopal Vijayaraghavan
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-25011.1.patch, HIVE-25011.2.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {code}
> EXPLAIN UPDATE ...
> {code}
> should not be in conflict with another active ongoing UPDATE operation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
