[
https://issues.apache.org/jira/browse/HIVE-25633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432472#comment-17432472
]
Zoltan Haindrich commented on HIVE-25633:
-----------------------------------------
Thank you [~euigeun_chung] for chiming in!
I opted to remove the shutdown call - because these threads will have the
daemon flag set.
By the way the HiveMetaStore also shuts down the ThreadPool when it goes down
[here|https://github.com/apache/hive/blob/4df4b769e8217b2a40ce74f415a859379ab13986/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L300]
- however in case of an embedded metastore it might not be called.
> Prevent shutdown of MetaStore scheduled worker ThreadPool
> ---------------------------------------------------------
>
> Key: HIVE-25633
> URL: https://issues.apache.org/jira/browse/HIVE-25633
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> [~lpinter] have noticed that this patch has some sideffect:
> in HIVE-23164 the patch have added a {{ThreadPool#shutdown}} to
> {{HMSHandler#shutdown}} - which could cause trouble in case a {{HMSHandler}}
> is shutdown and a new one is created
> I was looking for cases in which a HMSHandler is created inside the metastore
> (beyond the one HiveMetaStore is using) - and I think tasks like
> PartitionManagementTask which uses Msck which uses HMC to access the
> metastore - and they close the client - which closes the hmshandler client ;
> which will shut down the threadpool
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
