[
https://issues.apache.org/jira/browse/HIVE-25659?focusedWorklogId=671880&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-671880
]
ASF GitHub Bot logged work on HIVE-25659:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/21 09:00
Start Date: 29/Oct/21 09:00
Worklog Time Spent: 10m
Work Description: adesh-rao commented on a change in pull request #2758:
URL: https://github.com/apache/hive/pull/2758#discussion_r739059612
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
##########
@@ -680,6 +680,9 @@ public static ConfVars getMetaConf(String name) {
DIRECT_SQL_MAX_ELEMENTS_VALUES_CLAUSE("metastore.direct.sql.max.elements.values.clause",
"hive.direct.sql.max.elements.values.clause",
1000, "The maximum number of values in a VALUES clause for INSERT
statement."),
+ DIRECT_SQL_MAX_PARAMETERS("metastore.direct.sql.max.parameters",
+ "hive.direct.sql.max.parameters", 1000, "The maximum parameters the\n"
+
Review comment:
Why is this being set to 1000? What is the minimum number of parameters
supported across different db like mysql/mssql/postgres etc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 671880)
Time Spent: 20m (was: 10m)
> Divide IN/(NOT IN) queries based on number of max parameters SQL engine can
> support
> -----------------------------------------------------------------------------------
>
> Key: HIVE-25659
> URL: https://issues.apache.org/jira/browse/HIVE-25659
> Project: Hive
> Issue Type: Bug
> Components: Standalone Metastore
> Affects Versions: 3.1.0, 4.0.0
> Reporter: Nikhil Gupta
> Assignee: Nikhil Gupta
> Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Function
> org.apache.hadoop.hive.metastore.txn.TxnUtils#buildQueryWithINClauseStrings
> can generate queries with huge number of parameters with very small value ofÂ
> DIRECT_SQL_MAX_ELEMENTS_IN_CLAUSE and DIRECT_SQL_MAX_QUERY_LENGTH while
> generating delete query for completed_compactions table
> Example:
> {code:java}
> DIRECT_SQL_MAX_ELEMENTS_IN_CLAUSE = 100
> DIRECT_SQL_MAX_QUERY_LENGTH = 10 (10 KB)
> Number of parameters in a single query = 4759
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
