[
https://issues.apache.org/jira/browse/HIVE-25626?focusedWorklogId=671935&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-671935
]
ASF GitHub Bot logged work on HIVE-25626:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/21 12:19
Start Date: 29/Oct/21 12:19
Worklog Time Spent: 10m
Work Description: zabetak commented on a change in pull request #2734:
URL: https://github.com/apache/hive/pull/2734#discussion_r739184522
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -3011,9 +3011,14 @@ private RelNode genTableLogicalPlan(String tableAlias,
QB qb) throws SemanticExc
final String user =
tabMetaData.getProperty(Constants.JDBC_USERNAME);
String pswd = tabMetaData.getProperty(Constants.JDBC_PASSWORD);
if (pswd == null) {
- String keystore =
tabMetaData.getProperty(Constants.JDBC_KEYSTORE);
- String key = tabMetaData.getProperty(Constants.JDBC_KEY);
- pswd = Utilities.getPasswdFromKeystore(keystore, key);
+ if(!(tabMetaData.getProperty(Constants.JDBC_PASSWORD_URI) ==
null)) {
+ pswd =
Utilities.getPasswdFromUri(tabMetaData.getProperty(Constants.JDBC_PASSWORD_URI));
+ }
+ else {
+ String keystore =
tabMetaData.getProperty(Constants.JDBC_KEYSTORE);
+ String key = tabMetaData.getProperty(Constants.JDBC_KEY);
+ pswd = Utilities.getPasswdFromKeystore(keystore, key);
+ }
Review comment:
Sure we can defer the test for later. Please create another JIRA and
link with HIVE-25626 so that we don't forget.
Please have a look on my comments in
https://github.com/apache/hive/pull/2734/commits/e64d9af1d7649f4c2c480edf48f2b519d1ce2e20
and if you are OK with this I can merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 671935)
Time Spent: 40m (was: 0.5h)
> JDBCStorageHandler CBO fails when JDBC_PASSWORD_URI is used
> -----------------------------------------------------------
>
> Key: HIVE-25626
> URL: https://issues.apache.org/jira/browse/HIVE-25626
> Project: Hive
> Issue Type: Bug
> Components: Hive, JDBC storage handler
> Affects Versions: 3.1.2, 4.0.0
> Reporter: Chiran Ravani
> Assignee: Chiran Ravani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When table created with JDBCStorageHandler and JDBC_PASSWORD_URI is used as a
> password mechanism, CBO fails causing all the data to be fetched from DB and
> then processed in hive.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
