[
https://issues.apache.org/jira/browse/HIVE-25626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437580#comment-17437580
]
Harish JP commented on HIVE-25626:
----------------------------------
[~zabetak], Thank you for fixing this. I missed this in the initial patch, I
think we should get rid of one of the copy of constants. I searched using
JdbcStorageConfigManager and missed this.
Do you think it's better to use
JdbcStorageConfigManager.getPasswordFromProperties instead of duplicating the
logic? The ordering is preserved in the getPasswordFromProperties and should be
used everywhere instead of spreading the logic around. In the earlier patch I
consolidated 2 of them for the same reason.
> CBO fails when JDBC table specifies password via dbcp.password.uri
> ------------------------------------------------------------------
>
> Key: HIVE-25626
> URL: https://issues.apache.org/jira/browse/HIVE-25626
> Project: Hive
> Issue Type: Bug
> Components: Hive, JDBC storage handler
> Affects Versions: 3.1.2, 4.0.0
> Reporter: Chiran Ravani
> Assignee: Chiran Ravani
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When table created with JDBCStorageHandler and JDBC_PASSWORD_URI is used as a
> password mechanism, CBO fails causing all the data to be fetched from DB and
> then processed in hive.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
