[
https://issues.apache.org/jira/browse/HIVE-25676?focusedWorklogId=677331&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-677331
]
ASF GitHub Bot logged work on HIVE-25676:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/21 19:38
Start Date: 05/Nov/21 19:38
Worklog Time Spent: 10m
Work Description: zabetak opened a new pull request #2766:
URL: https://github.com/apache/hive/pull/2766
### What changes were proposed in this pull request?
1. Catch the exception and log the problem instead of propagating it.
2. Removing redundant isEmpty() check (Minor refactoring).
### Why are the changes needed?
To allow subsequent cleanup actions to run and avoid unrelated failures in
other tests.
### Does this PR introduce _any_ user-facing change?
Improves developer experience by protecting against unrelated failures.
### How was this patch tested?
Manually causing failures in `cleanupDockerContainer` and monitoring the
impact in other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 677331)
Time Spent: 20m (was: 10m)
> Uncaught exception in QTestDatabaseHandler#afterTest causes unrelated test
> failures
> -----------------------------------------------------------------------------------
>
> Key: HIVE-25676
> URL: https://issues.apache.org/jira/browse/HIVE-25676
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When for some reason we fail to cleanup a database after running a test using
> the {{qt:database}} option an exception is raised and propagates up the
> stack. Not catching it in
> [QTestDatabaseHandler#afterTest|https://github.com/apache/hive/blob/0616bcaa2436ccbf388b635bfea160b47849553c/itests/util/src/main/java/org/apache/hadoop/hive/ql/qoption/QTestDatabaseHandler.java#L124]
> disrupts subsequent cleanup actions, which are not executed, and leads to
> failures in subsequent tests which are not related.
>
> Moreover, the exception leaves {{QTestDatabaseHandler}} in an invalid state
> since the internal map holding the running databases is not updated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
