[
https://issues.apache.org/jira/browse/HIVE-25710?focusedWorklogId=685238&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685238
]
ASF GitHub Bot logged work on HIVE-25710:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/21 13:03
Start Date: 23/Nov/21 13:03
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #2796:
URL: https://github.com/apache/hive/pull/2796#discussion_r755102120
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/truncate/TruncateTableAnalyzer.java
##########
@@ -116,10 +116,13 @@ private void checkTruncateEligibility(ASTNode ast,
ASTNode root, String tableNam
private void addTruncateTableOutputs(ASTNode root, Table table, Map<String,
String> partitionSpec)
throws SemanticException {
- boolean truncateKeepsDataFiles = AcidUtils.isTransactionalTable(table) &&
- MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.TRUNCATE_ACID_USE_BASE);
+ boolean truncateUseBase = (HiveConf.getBoolVar(conf,
HiveConf.ConfVars.HIVE_ACID_TRUNCATE_USE_BASE)
+ || HiveConf.getBoolVar(conf,
HiveConf.ConfVars.HIVE_ACID_LOCKLESS_READS_ENABLED))
Review comment:
It didn't work (only in tests). Not sure if we need to deprecate old
property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 685238)
Time Spent: 1h 10m (was: 1h)
> Config used to enable non-blocking TRUNCATE is not properly propagated
> ----------------------------------------------------------------------
>
> Key: HIVE-25710
> URL: https://issues.apache.org/jira/browse/HIVE-25710
> Project: Hive
> Issue Type: Sub-task
> Reporter: Denys Kuzmenko
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
