[
https://issues.apache.org/jira/browse/HIVE-24546?focusedWorklogId=685837&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685837
]
ASF GitHub Bot logged work on HIVE-24546:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Nov/21 13:40
Start Date: 24/Nov/21 13:40
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #2545:
URL: https://github.com/apache/hive/pull/2545#discussion_r756085431
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java
##########
@@ -910,12 +910,12 @@ private void updateDPCounters(final FSPaths fsp, final
int filesIdx) {
}
private void createDpDirCheckSrc(final Path dpStagingPath, final Path
dpFinalPath) throws IOException {
- if (!fs.exists(dpStagingPath) && !fs.exists(dpFinalPath)) {
Review comment:
I don't fully understand why we had `dpFinalPath` as a parameter to this
method; and why was it also checked before creating the `dpStagingPath` => if
`dpFinalPath` was already existed the staging dir was not created....I don't
know if that was a bug or intentional....
but now this `dpFinalPath` also become unused; so it could be removed from
the function signature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 685837)
Time Spent: 40m (was: 0.5h)
> Avoid unwanted cloud storage call during dynamic partition load
> ---------------------------------------------------------------
>
> Key: HIVE-24546
> URL: https://issues.apache.org/jira/browse/HIVE-24546
> Project: Hive
> Issue Type: Improvement
> Reporter: Rajesh Balamohan
> Priority: Major
> Labels: pull-request-available
> Attachments: simple_test.sql
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {code:java}
> private void createDpDirCheckSrc(final Path dpStagingPath, final Path
> dpFinalPath) throws IOException {
> if (!fs.exists(dpStagingPath) && !fs.exists(dpFinalPath)) {
> fs.mkdirs(dpStagingPath);
> // move task will create dp final path
> if (reporter != null) {
> reporter.incrCounter(counterGroup,
> Operator.HIVE_COUNTER_CREATED_DYNAMIC_PARTITIONS, 1);
> }
> }
> }
> {code}
>
>
> {noformat}
> at org.apache.hadoop.fs.s3a.Invoker.retryUntranslated(Invoker.java:370)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.listObjects(S3AFileSystem.java:1960)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.s3GetFileStatus(S3AFileSystem.java:3164)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.innerGetFileStatus(S3AFileSystem.java:3031)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.getFileStatus(S3AFileSystem.java:2899)
> at org.apache.hadoop.fs.FileSystem.exists(FileSystem.java:1723)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.exists(S3AFileSystem.java:4157)
> at
> org.apache.hadoop.hive.ql.exec.FileSinkOperator.createDpDir(FileSinkOperator.java:948)
> at
> org.apache.hadoop.hive.ql.exec.FileSinkOperator.updateDPCounters(FileSinkOperator.java:916)
> at
> org.apache.hadoop.hive.ql.exec.FileSinkOperator.createBucketForFileIdx(FileSinkOperator.java:849)
> at
> org.apache.hadoop.hive.ql.exec.FileSinkOperator.createBucketFiles(FileSinkOperator.java:814)
> at
> org.apache.hadoop.hive.ql.exec.FileSinkOperator.createNewPaths(FileSinkOperator.java:1200)
> at
> org.apache.hadoop.hive.ql.exec.FileSinkOperator.getDynOutPaths(FileSinkOperator.java:1324)
> at
> org.apache.hadoop.hive.ql.exec.FileSinkOperator.process(FileSinkOperator.java:1036)
> at
> org.apache.hadoop.hive.ql.exec.vector.VectorFileSinkOperator.process(VectorFileSinkOperator.java:111)
> at
> org.apache.hadoop.hive.ql.exec.Operator.vectorForward(Operator.java:969)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
