[
https://issues.apache.org/jira/browse/HIVE-25736?focusedWorklogId=686279&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-686279
]
ASF GitHub Bot logged work on HIVE-25736:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Nov/21 08:08
Start Date: 25/Nov/21 08:08
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2813:
URL: https://github.com/apache/hive/pull/2813#discussion_r756651986
##########
File path:
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestNewInputOutputFormat.java
##########
@@ -225,7 +225,8 @@ public void testNewOutputFormat() throws Exception {
assertEquals(intWritable.get(), firstIntValue);
assertEquals(text.toString(), firstStringValue);
Review comment:
This is test only code. If we would like to do this correctly, then we
should use try-with-resources block for every reader. That would mean serious
refactor of the affected classes. Which would mean manual backporting every
change affecting those.
If you still feel that we should do it, I am happy to do the change. I
wanted to keep the change small and manageable.
Thanks, Peter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 686279)
Time Spent: 50m (was: 40m)
> Close ORC readers
> -----------------
>
> Key: HIVE-25736
> URL: https://issues.apache.org/jira/browse/HIVE-25736
> Project: Hive
> Issue Type: Bug
> Reporter: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> After ORC-498 the Orc readers should be closed explicitly. One of the cases
> was HIVE-25683, but there are several places where the ORC readers are still
> not closed.
> We should go through the code and make sure that the readers are closed.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
