[
https://issues.apache.org/jira/browse/HIVE-25744?focusedWorklogId=687242&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687242
]
ASF GitHub Bot logged work on HIVE-25744:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/21 10:57
Start Date: 29/Nov/21 10:57
Worklog Time Spent: 10m
Work Description: kasakrisz opened a new pull request #2821:
URL: https://github.com/apache/hive/pull/2821
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
1. Restore the original type of `CreationMetadata.tablesUsed`
2. Add new optional field `CreationMetadata.soruceTables`
3. Wrap the generated `CreationMetadata` object into
`MaterializedViewMetadata` and extract `CreationMetadata` operations.
### Why are the changes needed?
See HIVE-25656 description
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
```
mvn test
-Dtest=TestDbTxnManagerIsolationProperties#testRebuildMVWhenOpenTxnPresents -pl
ql
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 687242)
Remaining Estimate: 0h
Time Spent: 10m
> Support backward compatibility of thrift struct CreationMetadata
> ----------------------------------------------------------------
>
> Key: HIVE-25744
> URL: https://issues.apache.org/jira/browse/HIVE-25744
> Project: Hive
> Issue Type: Task
> Components: Materialized views, Thrift API
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Old
> {code}
> struct CreationMetadata {
> 1: required string catName
> 2: required string dbName,
> 3: required string tblName,
> 4: required set<string> tablesUsed,
> 5: optional string validTxnList,
> 6: optional i64 materializationTime
> }HIVE-25656 introduced a breaking change in the HiveServer2 <-> Metastore
> thrift api:
> {code}
> New
> {code}
> struct CreationMetadata {
> 1: required string catName
> 2: required string dbName,
> 3: required string tblName,
> 4: required set<SourceTable> tablesUsed,
> 5: optional string validTxnList,
> 6: optional i64 materializationTime
> }
> {code}
> 4th field type changed
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
