[
https://issues.apache.org/jira/browse/HIVE-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965569#comment-14965569
]
David McWhorter commented on HIVE-6705:
---------------------------------------
I don't think the behavior of this patch is right. Since hive does not yet
support manual transactions, all statements autocommit. So, the behavior of
isAutoCommit is correct, and setAutoCommit should silently allow autoCommit =
true but throw an exception saying the operation is not support if if
autocommit = false.
So the patch should look like
```
if (!autoCommit) {
throw new SQLException("disabling autocommit is not supported");
}
```
> hive jdbc can not used by jmeter, because of unsupported auto commit feature
> ----------------------------------------------------------------------------
>
> Key: HIVE-6705
> URL: https://issues.apache.org/jira/browse/HIVE-6705
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 0.12.0
> Environment: CentOS_X86_64
> JMeter 2.11
> Reporter: Ben
> Assignee: Navis
> Attachments: HIVE-6705.1.patch.txt, HIVE-6705.2.patch.txt
>
>
> In apache jmeter ,the autocommit property is required.
> but in the hive jdbc the auto commit is unsupported method.
> in
> /jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
> {quote}
> public void setAutoCommit(boolean autoCommit) throws SQLException {
> // TODO Auto-generated method stub
> throw new {color:red} SQLException("Method not supported");
> {color}
> }
> {quote}
> so ,should we make a mock to support the auto commit property == false ?
> {quote}
> public void setAutoCommit(boolean autoCommit) throws SQLException {
> // TODO Auto-generated method stub
> {color:red}if(autoCommit) {color}
> throw new SQLException("Method not supported");
> else
> return;
> }
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
