[ 
https://issues.apache.org/jira/browse/HIVE-25788?focusedWorklogId=692325&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-692325
 ]

ASF GitHub Bot logged work on HIVE-25788:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Dec/21 08:59
            Start Date: 08/Dec/21 08:59
    Worklog Time Spent: 10m 
      Work Description: pvary commented on a change in pull request #2847:
URL: https://github.com/apache/hive/pull/2847#discussion_r764665772



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -7705,6 +7705,13 @@ protected Operator genFileSinkPlan(String dest, QB qb, 
Operator input)
       } else {
         tableDescriptor = PlanUtils.getTableDesc(tblDesc, cols, colTypes);
       }
+
+      // if available, set location in table desc properties
+      if (tblDesc != null && tblDesc.getLocation() != null && tableDescriptor 
!= null &&
+          
!tableDescriptor.getProperties().containsKey(hive_metastoreConstants.META_TABLE_LOCATION))
 {

Review comment:
       how does this work with the HMSTranslators? (These are the stuff which 
makes sure that external/managed table is put into the correct location)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 692325)
    Time Spent: 40m  (was: 0.5h)

> Iceberg CTAS should honor location clause and have correct table properties
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-25788
>                 URL: https://issues.apache.org/jira/browse/HIVE-25788
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Marton Bod
>            Assignee: Marton Bod
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently Iceberg CTAS does not take the LOCATION clause into consideration. 
> Also, these tables end up with some unintended table properties coming from 
> the SerDe, such as partition.columns or partition.columns.comments, etc.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to