[
https://issues.apache.org/jira/browse/HIVE-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksei Statkevich updated HIVE-12213:
--------------------------------------
Attachment: HIVE-12231.1.patch
I changed updateTableStatsFast() to not update fast stats if there are no files.
However, I think it's better not to change "populateQuickStats()" in the same
way. One reason is that unlike "updateTableStatsFast()" it doesn't return a
value indicating whether stats are updated or not. It might confuse callers of
this method if they call it, but nothing happens. The second reason is that
this method is called from several places, including stats for partitions and
stats task. Again, they might not expect this modification. Finally, in cases
when it's called it's assumed by a calling method that stats are updated.
Also, I fixed the cases of assertEquals to follow the order of (expected,
actual). Removed one unused field from the test.
> Investigating the test failure TestHCatClient.testTableSchemaPropagation
> ------------------------------------------------------------------------
>
> Key: HIVE-12213
> URL: https://issues.apache.org/jira/browse/HIVE-12213
> Project: Hive
> Issue Type: Test
> Components: Test
> Affects Versions: 2.0.0
> Reporter: Aihua Xu
> Assignee: Aleksei Statkevich
> Priority: Minor
> Attachments: HIVE-12213.patch, HIVE-12231.1.patch
>
>
> The test has been failing for some time with following error.
> {noformat}
> Error Message
> Table after deserialization should have been identical to sourceTable.
> expected:<[TABLE_PROPERTIES]> but was:<[]>
> Stacktrace
> java.lang.AssertionError: Table after deserialization should have been
> identical to sourceTable. expected:<[TABLE_PROPERTIES]> but was:<[]>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at
> org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation(TestHCatClient.java:1065)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
