[
https://issues.apache.org/jira/browse/HIVE-25801?focusedWorklogId=697343&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-697343
]
ASF GitHub Bot logged work on HIVE-25801:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Dec/21 16:40
Start Date: 16/Dec/21 16:40
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #2879:
URL: https://github.com/apache/hive/pull/2879#discussion_r770724374
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -506,10 +478,23 @@ protected Boolean findNextCompactionAndExecute(boolean
computeStats) {
task (currently we're using Tez split grouping).
*/
QueryCompactor queryCompactor =
QueryCompactorFactory.getQueryCompactor(t, conf, ci);
+ boolean generic_stats =
conf.getBoolVar(HiveConf.ConfVars.HIVE_COMPACTOR_GATHER_STATS);
+ boolean mr_stats =
conf.getBoolVar(HiveConf.ConfVars.HIVE_MR_COMPACTOR_GATHER_STATS);
+ boolean computeStats = (queryCompactor == null && (mr_stats ||
generic_stats)) || generic_stats;
+
+ LOG.info("Starting " + ci.type.toString() + " compaction for " +
ci.getFullPartitionName() + " in " +
+ compactionTxn + " with compute stats set to " + computeStats);
+
+ StatsUpdater su = null;
+ if (computeStats) {
+ su = StatsUpdater.init(ci, conf, runJobAsSelf(ci.runAs) ? ci.runAs :
t.getOwner(),
Review comment:
Q. can we refactor StatsUpdater to a service utility that just submits
the compute stats query and not generate a separate instance per each
compaction candidate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 697343)
Time Spent: 50m (was: 40m)
> Custom queue settings is not honoured by Query based compaction StatsUpdater
> ----------------------------------------------------------------------------
>
> Key: HIVE-25801
> URL: https://issues.apache.org/jira/browse/HIVE-25801
> Project: Hive
> Issue Type: Bug
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {{hive.compactor.job.queue}} config limits resources available for
> compaction, so users can limit the effects of compaction on the cluster.
> However this settings does not affect stats collection which uses Driver.
> HIVE-25595 is addressing the above issue for MR-based compaction. We need to
> incorporate the same thing for the Query-based compaction.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
