[
https://issues.apache.org/jira/browse/HIVE-23971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ping Xu reassigned HIVE-23971:
------------------------------
Assignee: Ping Xu (was: Vihang Karajgaonkar)
> Cleanup unreleased method signatures in IMetastoreClient
> --------------------------------------------------------
>
> Key: HIVE-23971
> URL: https://issues.apache.org/jira/browse/HIVE-23971
> Project: Hive
> Issue Type: Improvement
> Reporter: Vihang Karajgaonkar
> Assignee: Ping Xu
> Priority: Blocker
>
> There are many methods in IMetastoreClient which are simply wrappers around
> another method. The code has become very intertwined and needs some cleanup.
> For instance, I see the following variations of {{getPartitionsByNames}} in
> {{IMetastoreClient}}
> {noformat}
> List<Partition> getPartitionsByNames(String db_name, String tbl_name,
> List<String> part_names, boolean getColStats, String engine)
> List<Partition> getPartitionsByNames(String catName, String db_name, String
> tbl_name, List<String> part_names)
> List<Partition> getPartitionsByNames(String catName, String db_name, String
> tbl_name, List<String> part_names, boolean getColStats, String engine)
> {noformat}
> The problem seems be that every time a new field is added to the request
> object {{GetPartitionsByNamesRequest}} and new variant is introduced in
> IMetastoreClient. Many of these methods are not released yet and it would be
> good to clean them up by using the request object as method argument instead
> of individual fields. Once we release we will not be able to change the
> method signatures since we annotate IMetastoreClient as public API.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
