[
https://issues.apache.org/jira/browse/HIVE-25801?focusedWorklogId=706898&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-706898
]
ASF GitHub Bot logged work on HIVE-25801:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/22 14:43
Start Date: 11/Jan/22 14:43
Worklog Time Spent: 10m
Work Description: veghlaci05 commented on a change in pull request #2879:
URL: https://github.com/apache/hive/pull/2879#discussion_r782214222
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -3257,11 +3257,23 @@ private static void
populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
HIVE_COMPACTOR_WAIT_TIMEOUT("hive.compactor.wait.timeout", 300000L, "Time
out in "
+ "milliseconds for blocking compaction. It's value has to be higher
than 2000 milliseconds. "),
- HIVE_MR_COMPACTOR_GATHER_STATS("hive.mr.compactor.gather.stats", true, "If
set to true MAJOR compaction " +
+ /**
+ * @deprecated This config value is honoured by the MR based compaction
only.
+ * Use the {@link HiveConf.ConfVars#HIVE_COMPACTOR_GATHER_STATS}
+ * config instead which is honoured by both the MR and Query based
compaction.
+ */
+ @Deprecated
+ HIVE_MR_COMPACTOR_GATHER_STATS("hive.mr.compactor.gather.stats", false,
"If set to true MAJOR compaction " +
"will gather stats if there are stats already associated with the
table/partition.\n" +
"Turn this off to save some resources and the stats are not used
anyway.\n" +
"Works only for MR based compaction, CRUD based compaction uses
hive.stats.autogather."),
+ HIVE_COMPACTOR_GATHER_STATS("hive.compactor.gather.stats", true, "If set
to true MAJOR compaction " +
Review comment:
Yes, this is the current behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 706898)
Time Spent: 3.5h (was: 3h 20m)
> Custom queue settings is not honoured by Query based compaction StatsUpdater
> ----------------------------------------------------------------------------
>
> Key: HIVE-25801
> URL: https://issues.apache.org/jira/browse/HIVE-25801
> Project: Hive
> Issue Type: Bug
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> {{hive.compactor.job.queue}} config limits resources available for
> compaction, so users can limit the effects of compaction on the cluster.
> However this settings does not affect stats collection which uses Driver.
> HIVE-25595 is addressing the above issue for MR-based compaction. We need to
> incorporate the same thing for the Query-based compaction.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
