[
https://issues.apache.org/jira/browse/HIVE-25667?focusedWorklogId=709671&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-709671
]
ASF GitHub Bot logged work on HIVE-25667:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/22 21:44
Start Date: 16/Jan/22 21:44
Worklog Time Spent: 10m
Work Description: mbathori-cloudera edited a comment on pull request
#2919:
URL: https://github.com/apache/hive/pull/2919#issuecomment-1013958037
It seems like the metastore verify stage is failing in the pipeline because
I refactored the DbInstall tests and it still tries to run the
ITestDerby,ITestMysql and ITestPostgres but they don’t exist anymore. All of
these tests are now running in ITestDbInstall. I’m not sure if the pipeline
needs to be adjusted to the changes or should I restore the original form of
these tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 709671)
Time Spent: 2h 20m (was: 2h 10m)
> Unify code managing JDBC databases in tests
> -------------------------------------------
>
> Key: HIVE-25667
> URL: https://issues.apache.org/jira/browse/HIVE-25667
> Project: Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Affects Versions: 4.0.0
> Reporter: Stamatis Zampetakis
> Assignee: Mark Bathori
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Currently there are two class hierarchies managing JDBC databases in tests,
> [DatabaseRule|https://github.com/apache/hive/blob/d35de014dd49fdcfe0aacb68e6c587beff6d1dea/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/DatabaseRule.java]
> and
> [AbstractExternalDB|https://github.com/apache/hive/blob/d35de014dd49fdcfe0aacb68e6c587beff6d1dea/itests/util/src/main/java/org/apache/hadoop/hive/ql/externalDB/AbstractExternalDB.java].
> There are many similarities between these hierarchies and certain parts are
> duplicated.
> The goal of this JIRA is to refactor the aforementioned hierarchies to reduce
> code duplication and improve extensibility.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
