[
https://issues.apache.org/jira/browse/HIVE-25884?focusedWorklogId=721783&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-721783
]
ASF GitHub Bot logged work on HIVE-25884:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/22 09:11
Start Date: 07/Feb/22 09:11
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #2957:
URL: https://github.com/apache/hive/pull/2957#discussion_r800446246
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterJoinRule.java
##########
@@ -130,7 +130,7 @@ public void onMatch(RelOptRuleCall call) {
public static class HiveFilterJoinTransposeRule extends HiveFilterJoinRule {
public HiveFilterJoinTransposeRule() {
- super(RelOptRule.operand(Join.class, RelOptRule.any()),
"HiveFilterJoinRule:no-filter", true,
+ super(RelOptRule.operand(Join.class, RelOptRule.any()),
"HiveFilterJoinTransposeRule", true,
Review comment:
this could also be handled by `getClass().getSimpleName()` - I think
that would have worked in the superclass as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 721783)
Time Spent: 0.5h (was: 20m)
> Improve rule description for rules defined as subclasses
> --------------------------------------------------------
>
> Key: HIVE-25884
> URL: https://issues.apache.org/jira/browse/HIVE-25884
> Project: Hive
> Issue Type: Improvement
> Components: CBO
> Affects Versions: 4.0.0
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Consider the instances of _HivePointLookupOptimizerRule_ (for joins, filters
> and projects).
> They use the [default
> constructor|https://github.com/apache/calcite/blob/0065d7c179b98698f018f83b0af0845a6698fc54/core/src/main/java/org/apache/calcite/plan/RelOptRule.java#L79]
> for _RelOptRule_, which builds the rule description from the class name, and
> in case of nested classes, it takes only the inner class name.
> In this case, the names do not refer to _HivePointLookupOptimizerRule_ and
> are too generic (e.g.,_FilerCondition_), it's hard to link them back to the
> rule they belong to without looking at the source code.
> This is particularly problematic now that we have more detailed logging for
> CBO (see [HIVE-25816|https://issues.apache.org/jira/browse/HIVE-25816]),
> where rule descriptions are printed.
> The aim of the PR is to improve the rule description by passing an explicit
> string whenever the rule (class) name alone is not enough.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
