[
https://issues.apache.org/jira/browse/HIVE-25938?focusedWorklogId=725262&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-725262
]
ASF GitHub Bot logged work on HIVE-25938:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/22 16:25
Start Date: 11/Feb/22 16:25
Worklog Time Spent: 10m
Work Description: jfsii commented on a change in pull request #3011:
URL: https://github.com/apache/hive/pull/3011#discussion_r804809478
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -2026,6 +2038,8 @@ protected RelNode
applyMaterializedViewRewriting(RelOptPlanner planner, RelNode
// Optimize plan
if (!ruleExclusionRegex.isEmpty()) {
+ LOG.debug("The CBO rules matching the following regex are excluded
from planning: {}",
Review comment:
I would maybe argue to make these info since they could modify planning
in strange ways and most users do not run with debug logging on. Sure they
could run EXPLAIN on the plan to see, but sometimes the person doing the
initial debugging doesn't have access to the EXPLAIN output (they just have a
set of logs and a description of "queries are returning wrong results").
Anyways - this is just a suggestion and if you feel different go ahead and
ignore because I can see the other argument of not wanting to add more INFO log
lines.
Thanks for this work @asolimando
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 725262)
Time Spent: 50m (was: 40m)
> Print excluded rules from CBO
> -----------------------------
>
> Key: HIVE-25938
> URL: https://issues.apache.org/jira/browse/HIVE-25938
> Project: Hive
> Issue Type: Improvement
> Components: CBO
> Affects Versions: 4.0.0
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> HIVE-25880 introduced a configuration parameter for excluding CBO rules based
> on a regex on their description.
> Calcite logs when a rule is excluded (see
> [AbstractRelOptPlanner.java#L316|https://github.com/apache/calcite/blob/e42b85a45bd16dd58db1546736e653deda5463fe/core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java#L316]
> and
> [VolcanoRuleCall.java#L169|https://github.com/apache/calcite/blob/e42b85a45bd16dd58db1546736e653deda5463fe/core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java#L169]).
> To ease investigations, this should be complemented by printing the regex
> used (if not blank) in Hive DEBUG logs, and the same in CBO information
> (i.e., EXPLAIN CBO's output).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
