[
https://issues.apache.org/jira/browse/HIVE-25981?focusedWorklogId=733811&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-733811
]
ASF GitHub Bot logged work on HIVE-25981:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/22 11:57
Start Date: 28/Feb/22 11:57
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #3052:
URL: https://github.com/apache/hive/pull/3052#discussion_r815824924
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -13130,8 +13131,7 @@ public void validate() throws SemanticException {
LOG.debug("validated " + usedp.getName());
LOG.debug(usedp.getTable().getTableName());
- WriteEntity.WriteType writeType = writeEntity.getWriteType();
- if (writeType != WriteType.UPDATE && writeType != WriteType.DELETE) {
+ if (!transactionalInQuery && conf.getBoolVar(HIVEARCHIVEENABLED)) {
Review comment:
@pvary
the variable is set based on that only above:
```
if (AcidUtils.isTransactionalTable(tbl)) {
transactionalInQuery = true;
```
At L13124, rather than re-doing AcidUtils.isTransactionalTable(tbl), making
use of the variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 733811)
Time Spent: 1h 20m (was: 1h 10m)
> Avoid checking for archived parts in analyze table
> --------------------------------------------------
>
> Key: HIVE-25981
> URL: https://issues.apache.org/jira/browse/HIVE-25981
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Reporter: Rajesh Balamohan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Analyze table on large partitioned table is expensive due to unwanted checks
> on archived data.
>
> {noformat}
> at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient$SynchronizedHandler.invoke(HiveMetaStoreClient.java:3908)
> - locked <0x00000003d4c4c070> (a
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient$SynchronizedHandler)
> at com.sun.proxy.$Proxy56.listPartitionsWithAuthInfo(Unknown Source)
> at org.apache.hadoop.hive.ql.metadata.Hive.getPartitions(Hive.java:3845)
> at
> org.apache.hadoop.hive.ql.exec.ArchiveUtils.conflictingArchiveNameOrNull(ArchiveUtils.java:299)
> at
> org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.validate(SemanticAnalyzer.java:13579)
> at org.apache.hadoop.hive.ql.Compiler.analyze(Compiler.java:241)
> at org.apache.hadoop.hive.ql.Compiler.compile(Compiler.java:104)
> at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:196)
> at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:615)
> at org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:561)
> at org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:555)
> at
> org.apache.hadoop.hive.ql.reexec.ReExecDriver.compileAndRespond(ReExecDriver.java:127)
> at
> org.apache.hive.service.cli.operation.SQLOperation.prepare(SQLOperation.java:204)
> at
> org.apache.hive.service.cli.operation.SQLOperation.runInternal(SQLOperation.java:265)
> at
> org.apache.hive.service.cli.operation.Operation.run(Operation.java:285)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
