[
https://issues.apache.org/jira/browse/HIVE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504161#comment-17504161
]
Peter Vary commented on HIVE-26021:
-----------------------------------
Fixed the Oracle error:
[https://github.com/apache/hive/pull/3081/commits/ae33179be2b2d3f70f716dd2bc5254f9963cfb42#diff-7e59262e7e9224f7dcb232a8b8d29f795b9ddd36339350396c17ba4d0eb871a6R1284]
I am not sure, but I guess that the tests took 2 (3) mins each after the docker
image has been downloaded. This might incur extra costs/time for the CI, if we
do it for every run. [~kgyrtkirk] might know more about them.
If we do not want to enable them on the PreCommit then one possible solution
could be to run them on the nightly build - so we can at least be sure that the
tests are running and the scripts are ok.
Your thoughts?
> Change integration tests under DBInstallBase to regular unit tests
> ------------------------------------------------------------------
>
> Key: HIVE-26021
> URL: https://issues.apache.org/jira/browse/HIVE-26021
> Project: Hive
> Issue Type: Improvement
> Components: Tests
> Reporter: Stamatis Zampetakis
> Priority: Major
>
> After HIVE-18588, some tests including those under
> [DBInstallBase|https://github.com/apache/hive/blob/1139c4b14db82a9e2316196819b35cfb713f34b5/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/DbInstallBase.java]
> class have been marked as integration tests mainly to keep the test duration
> low.
> Nowadays, Hive developers rarely run all tests locally so separating between
> integration tests and unit tests does not provide a clear benefit. The
> separation adds maintenance cost and makes their execution more difficult
> scaring people away.
> The goal of this issue is to change the tests under {{DBInstallBase}} from
> "integration" tests back to regular unit tests and run them as part of the
> standard maven test phase without any fancy arguments.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
