[
https://issues.apache.org/jira/browse/HIVE-26044?focusedWorklogId=745140&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745140
]
ASF GitHub Bot logged work on HIVE-26044:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/22 14:36
Start Date: 21/Mar/22 14:36
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #3115:
URL: https://github.com/apache/hive/pull/3115#discussion_r831178770
##########
File path:
itests/hive-unit/src/test/java/org/apache/hive/service/server/InformationSchemaWithPrivilegeTestBase.java
##########
@@ -287,7 +291,7 @@ public void test() throws Exception {
List<String> args = new ArrayList<String>(baseArgs);
args.add("-f");
-
args.add("../../metastore/scripts/upgrade/hive/hive-schema-4.0.0-alpha-1.hive.sql");
+ args.add("../../metastore/scripts/upgrade/hive/hive-schema-" +
hiveSchemaVer + ".hive.sql");
Review comment:
So HS2 version could be like `3.1.3000.2022.0.7.0`, HMS be like
`3.1.3000.7.2.11.0`, and and HMS DB version like `3.1.3000`? And the above 3
classes encode these 3 versions, respectively
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 745140)
Time Spent: 1h 40m (was: 1.5h)
> Remove hardcoded version references from the tests
> --------------------------------------------------
>
> Key: HIVE-26044
> URL: https://issues.apache.org/jira/browse/HIVE-26044
> Project: Hive
> Issue Type: Test
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> There are several places where there are hardcoded version references in the
> tests.
> We should remove them to so it is easier to change versions.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
