[
https://issues.apache.org/jira/browse/HIVE-26077?focusedWorklogId=749212&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-749212
]
ASF GitHub Bot logged work on HIVE-26077:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/22 09:01
Start Date: 29/Mar/22 09:01
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #3147:
URL: https://github.com/apache/hive/pull/3147#discussion_r837233568
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergTestUtils.java
##########
@@ -299,12 +300,14 @@ public static void validateDataWithSQL(TestHiveShell
shell, String tableName, Li
Assert.assertEquals(record.size(), row.length);
for (int j = 0; j < record.size(); ++j) {
Object field = record.get(j);
- if (field instanceof LocalDateTime) {
+ if (field == null) {
+ Assert.assertNull(row[j]);
+ } else if (field instanceof LocalDateTime) {
Assert.assertEquals(((LocalDateTime)
field).toInstant(ZoneOffset.UTC).toEpochMilli(),
TimestampUtils.stringToTimestamp((String)
row[j]).toEpochMilli());
} else if (field instanceof OffsetDateTime) {
Assert.assertEquals(((OffsetDateTime)
field).toInstant().toEpochMilli(),
- TimestampTZUtil.parse((String) row[j]).toEpochMilli());
+ TimestampTZUtil.parse((String) row[j],
ZoneId.systemDefault()).toEpochMilli());
Review comment:
Yeah. Without that, if the string does not contain the TZ, then
`TimestampTZUtil.parse` does not know which TZ it should use in parsing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 749212)
Time Spent: 0.5h (was: 20m)
> Implement CTAS for Iceberg tables with partition spec
> -----------------------------------------------------
>
> Key: HIVE-26077
> URL: https://issues.apache.org/jira/browse/HIVE-26077
> Project: Hive
> Issue Type: Task
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We enabled CTAS for Iceberg tables, but currently only for unpartitioned
> tables and tables where the partitioning schema uses the original HIVE
> {{PARTITIONED BY}} syntax.
> We would like to use CTAS with the new syntax, like:
> {code}
> CREATE TABLE t PARTITIONED BY SPEC(day(ts)) AS SELECT ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
