[ https://issues.apache.org/jira/browse/HIVE-26062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516245#comment-17516245 ]
Zhihua Deng commented on HIVE-26062: ------------------------------------ Pushed to master. Thank you for raising the jira and the review, [~pvary]! > Make sure that running 4.0.0-alpha-2 above 4.0.0-alpha-1 HMS DB reports the > correct error > ----------------------------------------------------------------------------------------- > > Key: HIVE-26062 > URL: https://issues.apache.org/jira/browse/HIVE-26062 > Project: Hive > Issue Type: Task > Reporter: Peter Vary > Assignee: Zhihua Deng > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0-alpha-2 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > When comparing expected and actual HMS DB versions the code has problems with > parsing {{alpha-1}}. We should make sure that the appropriate error message > is returned to the customer instead of a {{NumberFormatException}}. > Currently we have this, and we might just want to return {{false}} if there > is no exact match: > {code} > java.lang.NumberFormatException: For input string: "0-alpha-1" > at > java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) > at java.lang.Integer.parseInt(Integer.java:580) > at java.lang.Integer.parseInt(Integer.java:615) > at > org.apache.hadoop.hive.metastore.MetaStoreSchemaInfo.isVersionCompatible(MetaStoreSchemaInfo.java:210) > at > org.apache.hadoop.hive.metastore.ObjectStore.checkSchema(ObjectStore.java:10870) > at > org.apache.hadoop.hive.metastore.ObjectStore.verifySchema(ObjectStore.java:10839) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hadoop.hive.metastore.RawStoreProxy.invoke(RawStoreProxy.java:97) > at com.sun.proxy.$Proxy28.verifySchema(Unknown Source) > at > org.apache.hadoop.hive.metastore.HMSHandler.getMSForConf(HMSHandler.java:610) > at org.apache.hadoop.hive.metastore.HMSHandler.getMS(HMSHandler.java:602) > at > org.apache.hadoop.hive.metastore.HMSHandler.createDefaultDB(HMSHandler.java:686) > {code} -- This message was sent by Atlassian Jira (v8.20.1#820001)