[
https://issues.apache.org/jira/browse/HIVE-25934?focusedWorklogId=752130&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752130
]
ASF GitHub Bot logged work on HIVE-25934:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/22 08:43
Start Date: 04/Apr/22 08:43
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3015:
URL: https://github.com/apache/hive/pull/3015#discussion_r841497550
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2109,7 +2109,8 @@ struct RenamePartitionRequest {
3: required string tableName,
4: required list<string> partVals,
5: required Partition newPart,
- 6: optional string validWriteIdList
+ 6: optional string validWriteIdList,
+ 7: optional EnvironmentContext environmentContext
Review Comment:
RenamePartitionRequest is only used by thrift to pass the data, however,
it's not used by the server-side. All its internals are extracted into
individual params including `EnvironmentContext`.
HMSHandler.alterPartitionForTruncate, HiveAlterHandler.alterPartition do not
operate on request object, but individual params.
If we want to use RenamePartitionRequest that would require a major
refactor.
Currently, if I would simply extend RenamePartitionRequest with `txnid`
and`RENAME_MAKE_DATA_COPY` I would still need to pass them through the
`EnvironmentContext` on a server-side to avoid adding methods with the new
signature.
Issue Time Tracking
-------------------
Worklog Id: (was: 752130)
Time Spent: 2h 10m (was: 2h)
> Non blocking RENAME PARTITION implementation
> --------------------------------------------
>
> Key: HIVE-25934
> URL: https://issues.apache.org/jira/browse/HIVE-25934
> Project: Hive
> Issue Type: Task
> Reporter: Denys Kuzmenko
> Assignee: Denys Kuzmenko
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Implement RENAME PARTITION in a way that doesn't have to wait for currently
> running read operations to be finished.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
