[
https://issues.apache.org/jira/browse/HIVE-26102?focusedWorklogId=753992&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-753992
]
ASF GitHub Bot logged work on HIVE-26102:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Apr/22 11:37
Start Date: 07/Apr/22 11:37
Worklog Time Spent: 10m
Work Description: marton-bod commented on code in PR #3131:
URL: https://github.com/apache/hive/pull/3131#discussion_r845029785
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java:
##########
@@ -97,12 +100,22 @@ private void reparseAndSuperAnalyze(ASTNode tree) throws
SemanticException {
Table mTable = getTargetTable(tabName);
validateTargetTable(mTable);
+ // save the operation type into the query state
+ SessionStateUtil.addResource(conf,
Context.Operation.class.getSimpleName(), operation.name());
+
StringBuilder rewrittenQueryStr = new StringBuilder();
rewrittenQueryStr.append("insert into table ");
rewrittenQueryStr.append(getFullTableNameForSQL(tabName));
addPartitionColsToInsert(mTable.getPartCols(), rewrittenQueryStr);
- rewrittenQueryStr.append(" select ROW__ID");
+ boolean nonNativeAcid = mTable.getStorageHandler() != null &&
mTable.getStorageHandler().supportsAcidOperations();
Review Comment:
Sure, makes sense! I've added a util method to AcidUtils
Issue Time Tracking
-------------------
Worklog Id: (was: 753992)
Time Spent: 11.5h (was: 11h 20m)
> Implement DELETE statements for Iceberg tables
> ----------------------------------------------
>
> Key: HIVE-26102
> URL: https://issues.apache.org/jira/browse/HIVE-26102
> Project: Hive
> Issue Type: New Feature
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
