[
https://issues.apache.org/jira/browse/HIVE-26102?focusedWorklogId=754571&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-754571
]
ASF GitHub Bot logged work on HIVE-26102:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/22 13:00
Start Date: 08/Apr/22 13:00
Worklog Time Spent: 10m
Work Description: marton-bod commented on code in PR #3131:
URL: https://github.com/apache/hive/pull/3131#discussion_r846087296
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java:
##########
@@ -50,10 +50,14 @@
RAWDATASIZE("RAW__DATA__SIZE", TypeInfoFactory.longTypeInfo),
/**
- * {@link org.apache.hadoop.hive.ql.io.RecordIdentifier}
+ * {@link org.apache.hadoop.hive.ql.io.RecordIdentifier}
*/
ROWID("ROW__ID", RecordIdentifier.StructInfo.typeInfo, true,
RecordIdentifier.StructInfo.oi),
ROWISDELETED("ROW__IS__DELETED", TypeInfoFactory.booleanTypeInfo),
+ PARTITION_SPEC_ID("PARTITION__SPEC__ID", TypeInfoFactory.intTypeInfo),
+ PARTITION_HASH("PARTITION__HASH", TypeInfoFactory.longTypeInfo),
+ FILE_PATH("FILE__PATH", TypeInfoFactory.stringTypeInfo),
+ ROW_POSITION("ROW__POSITION", TypeInfoFactory.longTypeInfo),
Review Comment:
The row number is obtained in the `OrcRecordUpdater`:
```
ByteBuffer val =
reader.getMetadataValue(OrcRecordUpdater.ACID_KEY_INDEX_NAME)
```
then the stripe metadata is deserialized and this contains the row number
Issue Time Tracking
-------------------
Worklog Id: (was: 754571)
Time Spent: 13h 40m (was: 13.5h)
> Implement DELETE statements for Iceberg tables
> ----------------------------------------------
>
> Key: HIVE-26102
> URL: https://issues.apache.org/jira/browse/HIVE-26102
> Project: Hive
> Issue Type: New Feature
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 13h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)