[
https://issues.apache.org/jira/browse/HIVE-26123?focusedWorklogId=755169&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755169
]
ASF GitHub Bot logged work on HIVE-26123:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/22 10:09
Start Date: 11/Apr/22 10:09
Worklog Time Spent: 10m
Work Description: asolimando commented on PR #3196:
URL: https://github.com/apache/hive/pull/3196#issuecomment-1094860222
> I really don't like to grow the number of core cli test drivers; why do we
need separate for oracle/etc?
>
> can't we use a qoption instead of a whole set of new drivers?
>
> I wonder if we really need to have mile long q.out results for these kind
of things. I think these kind of things should be run as part of some automated
smoke tests for the release - with a real installation undernteath
The existing test infra could be improved in many ways, regarding the
metastore bit, there is already a ticket:
https://issues.apache.org/jira/browse/HIVE-26005.
We have discussed offline with @zabetak and we thought it would be better to
move forward with what we have, and to tackle the improvement in the other
ticket, since at the moment we already have broken support for mysql for sysdb:
https://issues.apache.org/jira/browse/HIVE-26125.
If you think HIVE-26005 is a must-do, please update the link between the
tickets accordingly and I will pause this until me or somebody else finds the
time to tackle it, otherwise if you agree that is better to have more coverage
now and improve tests later, I am open to suggestions on how to improve the
current proposal.
I have explored the qoption way you suggest (adding a metastore option to
sysdb qoption), I can start the sought docker containers, but changing the
configuration properties to use another metastore failed, the new cli driver
was the only way I could make these tests working.
Issue Time Tracking
-------------------
Worklog Id: (was: 755169)
Time Spent: 1h (was: 50m)
> Introduce test coverage for sysdb for the different metastores
> --------------------------------------------------------------
>
> Key: HIVE-26123
> URL: https://issues.apache.org/jira/browse/HIVE-26123
> Project: Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Affects Versions: 4.0.0-alpha-2
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-2
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> _sydb_ exposes (some of) the metastore tables from Hive via JDBC queries.
> Existing tests are running only against Derby, meaning that any change
> against sysdb query mapping is not covered by CI.
> The present ticket aims at bridging this gap by introducing test coverage for
> the different supported metastore for sydb.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
