[ 
https://issues.apache.org/jira/browse/HIVE-21456?focusedWorklogId=755360&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755360
 ]

ASF GitHub Bot logged work on HIVE-21456:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/22 18:14
            Start Date: 11/Apr/22 18:14
    Worklog Time Spent: 10m 
      Work Description: sourabh912 commented on code in PR #3105:
URL: https://github.com/apache/hive/pull/3105#discussion_r847608730


##########
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestSSL.java:
##########
@@ -437,15 +439,36 @@ public void testConnectionWrongCertCN() throws Exception {
    * Test HMS server with SSL
    * @throws Exception
    */
+  @Ignore
   @Test
   public void testMetastoreWithSSL() throws Exception {
     testSSLHMS(true);
   }
 
+  /**
+   * Test HMS server with Http + SSL
+   * @throws Exception
+   */
+  @Test
+  public void testMetastoreWithHttps() throws Exception {
+    // MetastoreConf.setBoolVar(conf, 
MetastoreConf.ConfVars.EVENT_DB_NOTIFICATION_API_AUTH, false);
+    //MetastoreConf.setVar(conf, 
MetastoreConf.ConfVars.METASTORE_CLIENT_TRANSPORT_MODE, "http");
+    SSLTestUtils.setMetastoreHttpsConf(conf);
+    MetastoreConf.setVar(conf, 
MetastoreConf.ConfVars.SSL_TRUSTMANAGERFACTORY_ALGORITHM,
+        KEY_MANAGER_FACTORY_ALGORITHM);
+    MetastoreConf.setVar(conf, MetastoreConf.ConfVars.SSL_TRUSTSTORE_TYPE, 
KEY_STORE_TRUST_STORE_TYPE);
+    MetastoreConf.setVar(conf, MetastoreConf.ConfVars.SSL_KEYSTORE_TYPE, 
KEY_STORE_TRUST_STORE_TYPE);
+    MetastoreConf.setVar(conf, 
MetastoreConf.ConfVars.SSL_KEYMANAGERFACTORY_ALGORITHM,
+        KEY_MANAGER_FACTORY_ALGORITHM);
+
+    testSSLHMS(false);

Review Comment:
   Thanks for pointing it out. I am setting the conf 
`MetastoreConf.ConfVars.SSL_KEYSTORE_TYPE`  in testSSLHMS(false) now.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 755360)
    Time Spent: 4h 10m  (was: 4h)

> Hive Metastore Thrift over HTTP
> -------------------------------
>
>                 Key: HIVE-21456
>                 URL: https://issues.apache.org/jira/browse/HIVE-21456
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore, Standalone Metastore
>            Reporter: Amit Khanna
>            Assignee: Sourabh Goyal
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21456.2.patch, HIVE-21456.3.patch, 
> HIVE-21456.4.patch, HIVE-21456.patch
>
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> Hive Metastore currently doesn't have support for HTTP transport because of 
> which it is not possible to access it via Knox. Adding support for Thrift 
> over HTTP transport will allow the clients to access via Knox



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to