[
https://issues.apache.org/jira/browse/HIVE-25787?focusedWorklogId=756340&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-756340
]
ASF GitHub Bot logged work on HIVE-25787:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/22 11:53
Start Date: 13/Apr/22 11:53
Worklog Time Spent: 10m
Work Description: maheshk114 commented on code in PR #3170:
URL: https://github.com/apache/hive/pull/3170#discussion_r849394666
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -5215,7 +5215,7 @@ private static void moveAcidFiles(String deltaFileType,
PathFilter pathFilter, F
bucketDest.toUri().toString());
try {
fs.rename(bucketSrc, bucketDest);
- if (newFiles != null) {
+ if (newFiles != null && !newFiles.contains(bucketDest)) {
Review Comment:
Have you checked why there is a duplicate path here ? And also use Set
instead of List. List will become very expensive if the number of files is
large.
Issue Time Tracking
-------------------
Worklog Id: (was: 756340)
Remaining Estimate: 0h
Time Spent: 10m
> Prevent duplicate paths in the fileList while adding an entry to
> NotifcationLog
> -------------------------------------------------------------------------------
>
> Key: HIVE-25787
> URL: https://issues.apache.org/jira/browse/HIVE-25787
> Project: Hive
> Issue Type: Bug
> Reporter: Ayush Saxena
> Assignee: Haymant Mangla
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As of now, while adding entries to notification logs, in case of retries,
> sometimes the same path gets added to the notification log entry, which
> during replication leads to failures during copy.
> Avoid having same path more than once for single transaction.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
