[
https://issues.apache.org/jira/browse/HIVE-26156?focusedWorklogId=759212&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759212
]
ASF GitHub Bot logged work on HIVE-26156:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/22 13:13
Start Date: 20/Apr/22 13:13
Worklog Time Spent: 10m
Work Description: szlta commented on code in PR #3225:
URL: https://github.com/apache/hive/pull/3225#discussion_r854074661
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergDeleteWriter.java:
##########
@@ -53,7 +54,8 @@ public class HiveIcebergDeleteWriter extends
HiveIcebergWriter {
public void write(Writable row) throws IOException {
Record rec = ((Container<Record>) row).get();
PositionDelete<Record> positionDelete =
IcebergAcidUtil.getPositionDelete(rec, rowDataTemplate);
- writer.write(positionDelete, spec, partition(positionDelete.row()));
+ Integer specId = rec.get(0, Integer.class);
Review Comment:
I guess this is meta column at position 0? Could you annotate with some
comments please?
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -374,9 +373,12 @@ public DynamicPartitionCtx createDPContext(HiveConf
hiveConf, org.apache.hadoop.
fieldOrderMap.put(fields.get(i).name(), i);
}
+ // deletes already use the bucket values in the partition_struct for
sorting, so no need to add the sort expression
Review Comment:
Is this true for bucket transform only? Is bucket() special for some reason,
or could we avoid sorting according to other partition columns (and transform
types) as well?
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergWriter.java:
##########
@@ -101,7 +101,14 @@ public void close(boolean abort) throws IOException {
}
protected PartitionKey partition(Record row) {
- currentKey.partition(wrapper.wrap(row));
- return currentKey;
+ // get partition key for the latest spec
+ return partition(row, specs.size() - 1);
Review Comment:
Same question for getting the latest spec.
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergRecordWriter.java:
##########
@@ -37,17 +38,17 @@
class HiveIcebergRecordWriter extends HiveIcebergWriter {
- HiveIcebergRecordWriter(Schema schema, PartitionSpec spec, FileFormat format,
+ HiveIcebergRecordWriter(Schema schema, Map<Integer, PartitionSpec> specs,
FileFormat format,
FileWriterFactory<Record> fileWriterFactory, OutputFileFactory
fileFactory, FileIO io, long targetFileSize,
TaskAttemptID taskAttemptID, String tableName) {
- super(schema, spec, io, taskAttemptID, tableName,
+ super(schema, specs, io, taskAttemptID, tableName,
new ClusteredDataWriter<>(fileWriterFactory, fileFactory, io, format,
targetFileSize));
}
@Override
public void write(Writable row) throws IOException {
Record record = ((Container<Record>) row).get();
- writer.write(record, spec, partition(record));
+ writer.write(record, specs.get(specs.size() - 1), partition(record));
Review Comment:
Are we trying to get the latest spec here? If so it could become problematic
if an older spec is reused to be the current one.
E.g: partition evolution goes as:
1. initially partitioned by col and col2 -> spec0: identity(col),
identity(col2); latest_spec=0
2. remove col from spec -> spec1: identity(col2); latest_spec=1
3. re-add col to spec -> no new spec is created; latest_spec=0
Issue Time Tracking
-------------------
Worklog Id: (was: 759212)
Remaining Estimate: 0h
Time Spent: 10m
> Iceberg delete writer should handle deleting from old partition specs
> ---------------------------------------------------------------------
>
> Key: HIVE-26156
> URL: https://issues.apache.org/jira/browse/HIVE-26156
> Project: Hive
> Issue Type: Bug
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While {{HiveIcebergRecordWriter}} always writes data out according to the
> latest spec, the {{HiveIcebergDeleteWriter}} might have to write delete files
> into partitions that correspond to a variety of specs, both old and new.
> Therefore we should pass the {{{}table.specs(){}}}map into the
> {{HiveIcebergWriter}} so that the delete writer can choose the appropriate
> spec on a per-record basis.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
