[
https://issues.apache.org/jira/browse/HIVE-26157?focusedWorklogId=759306&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759306
]
ASF GitHub Bot logged work on HIVE-26157:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/22 15:18
Start Date: 20/Apr/22 15:18
Worklog Time Spent: 10m
Work Description: marton-bod commented on code in PR #3226:
URL: https://github.com/apache/hive/pull/3226#discussion_r854264528
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -104,7 +106,7 @@
public class HiveIcebergStorageHandler implements HiveStoragePredicateHandler,
HiveStorageHandler {
private static final Logger LOG =
LoggerFactory.getLogger(HiveIcebergStorageHandler.class);
- private static final String ICEBERG_URI_PREFIX = "iceberg://";
+ private static final String ICEBERG_URI_PREFIX = "iceberg:/";
Review Comment:
Was this change necessary? I think it's supposed to work like a 'protocol'
that's why there is the double-slash. I think kafka and druid did the same
thing (i.e. `druid://` and `kafka://`)
Issue Time Tracking
-------------------
Worklog Id: (was: 759306)
Time Spent: 1h (was: 50m)
> Change Iceberg storage handler authz URI to metadata location
> -------------------------------------------------------------
>
> Key: HIVE-26157
> URL: https://issues.apache.org/jira/browse/HIVE-26157
> Project: Hive
> Issue Type: Improvement
> Reporter: László Pintér
> Assignee: László Pintér
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In HIVE-25964, the authz URI has been changed to "iceberg://db.table".
> It is possible to set the metadata pointers of table A to point to table B,
> and therefore you could read table B's data via querying table A.
> {code:sql}
> alter table A set tblproperties
> ('metadata_location'='/path/to/B/snapshot.json',
> 'previous_metadata_location'='/path/to/B/prev_snapshot.json'); {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)