[
https://issues.apache.org/jira/browse/HIVE-19711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526282#comment-17526282
]
Ádám Szita commented on HIVE-19711:
-----------------------------------
[~mgergely] it looks like this refactor has also incorporated a change in
behavior. Looking at your commit
[https://github.com/apache/hive/commit/d83a0be9852467b3b8b3bef84721bb49e63f57b8]
what I see is that:
After your change the validation task fails if there's any failures with
locations or columnNullValues:
[https://github.com/apache/hive/blob/d83a0be9852467b3b8b3bef84721bb49e63f57b8/beeline/src/java/org/apache/hive/beeline/schematool/HiveSchemaToolTaskValidate.java#L75-L76]
Before your change these used to be reported as WARNings only, and didn't cause
the validation task to actually fail:
[https://github.com/apache/hive/blob/e7d1781ec4662e088dcd6ffbe3f866738792ad9b/beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java#L622-L631]
Question: was this change in functionality on purpose? If so what was it? In
case it was unintentional, do you think the original behavior should be
restored?
> Refactor Hive Schema Tool
> -------------------------
>
> Key: HIVE-19711
> URL: https://issues.apache.org/jira/browse/HIVE-19711
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Affects Versions: 3.0.0
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Minor
> Fix For: 4.0.0, 4.0.0-alpha-1
>
> Attachments: HIVE-19711.01.patch, HIVE-19711.02.patch,
> HIVE-19711.03.patch, HIVE-19711.04.patch, HIVE-19711.05.patch,
> HIVE-19711.06.patch, HIVE-19711.07.patch, HIVE-19711.08.patch
>
>
> HiveSchemaTool is an 1500 lines long class trying to do everything It shold
> be cut into multiple classes doing smaller components.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
