[
https://issues.apache.org/jira/browse/HIVE-26169?focusedWorklogId=760818&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760818
]
ASF GitHub Bot logged work on HIVE-26169:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Apr/22 13:10
Start Date: 22/Apr/22 13:10
Worklog Time Spent: 10m
Work Description: marton-bod commented on code in PR #3236:
URL: https://github.com/apache/hive/pull/3236#discussion_r856213274
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -744,8 +745,17 @@ private String
collectColumnAndReplaceDummyValues(ExprNodeDesc node, String foun
return column;
}
- private void fallbackToNonVectorizedModeForV2(Properties tableProps) {
- if ("2".equals(tableProps.get(TableProperties.FORMAT_VERSION))) {
+ /**
+ * If any of the following checks is true we fall back to non vectorized
mode:
+ * <ul>
+ * <li>iceberg format-version is "2"</li>
+ * <li>fileformat is set to avro</li>
+ * </ul>
+ * @param tableProps table properties, must be not null
+ */
+ private void fallbackToNonVectorizedModeBasedOnProperties(Properties
tableProps) {
+ if ("2".equals(tableProps.get(TableProperties.FORMAT_VERSION)) ||
+ FileFormat.AVRO.name().equalsIgnoreCase((String)
tableProps.get(TableProperties.DEFAULT_FILE_FORMAT))) {
Review Comment:
nit: you can use `tablePros.getProperty()` instead of casting
Issue Time Tracking
-------------------
Worklog Id: (was: 760818)
Time Spent: 20m (was: 10m)
> Set non-vectorized mode as default when accessing iceberg tables in avro
> fileformat
> -----------------------------------------------------------------------------------
>
> Key: HIVE-26169
> URL: https://issues.apache.org/jira/browse/HIVE-26169
> Project: Hive
> Issue Type: Improvement
> Reporter: László Pintér
> Assignee: László Pintér
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Vectorization for iceberg tables in avro format is not yet supported. We
> should disable vectorization when we want to read/write avro tables.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
