[
https://issues.apache.org/jira/browse/HIVE-26148?focusedWorklogId=761625&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761625
]
ASF GitHub Bot logged work on HIVE-26148:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/22 07:31
Start Date: 25/Apr/22 07:31
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3218:
URL: https://github.com/apache/hive/pull/3218#discussion_r857332648
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java:
##########
@@ -46,11 +46,18 @@ public AuthorizationMetaStoreFilterHook(Configuration conf)
{
}
@Override
- public List<String> filterTableNames(String catName, String dbName,
List<String> tableList)
+ public List<String> filterTableNames(String dbName, List<String> tableList)
throws MetaException {
List<HivePrivilegeObject> listObjs = getHivePrivObjects(dbName, tableList);
return getTableNames(getFilteredObjects(listObjs));
}
+
+ @Override
+ public List<String> filterTableNames(String catName, String dbName,
List<String> tableList)
+ throws MetaException {
+ return filterTableNames(dbName, tableList);
Review Comment:
This seems problematic to me.
If we ignore the catalog name, that could become a serious hidden issue.
Do we have a better solution to this?
Maybe throw an exception if the catalog name is not the default? Or do the
filtering correctly with the catalog info as well?
Issue Time Tracking
-------------------
Worklog Id: (was: 761625)
Time Spent: 0.5h (was: 20m)
> Keep MetaStoreFilterHook interface compatibility after introducing catalogs
> ---------------------------------------------------------------------------
>
> Key: HIVE-26148
> URL: https://issues.apache.org/jira/browse/HIVE-26148
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Affects Versions: 3.0.0
> Reporter: Wechar
> Assignee: Wechar
> Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-1
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Hive 3.0 introduce catalog concept, when we upgrade hive dependency version
> from 2.3 to 3.x, we found some interfaces of *MetaStoreFilterHook* are not
> compatible:
> {code:bash}
> git show ba8a99e115 --
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java
> {code}
> {code:bash}
> ---
> a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java
> +++
> b/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java
> /**
> * Filter given list of tables
> - * @param dbName
> - * @param tableList
> + * @param catName catalog name
> + * @param dbName database name
> + * @param tableList list of table returned by the metastore
> * @return List of filtered table names
> */
> - public List<String> filterTableNames(String dbName, List<String>
> tableList) throws MetaException;
> + List<String> filterTableNames(String catName, String dbName, List<String>
> tableList)
> + throws MetaException;
> {code}
> We can remain the previous interfaces and use the default catalog to
> implement.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
