[
https://issues.apache.org/jira/browse/HIVE-26107?focusedWorklogId=761652&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761652
]
ASF GitHub Bot logged work on HIVE-26107:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/22 08:35
Start Date: 25/Apr/22 08:35
Worklog Time Spent: 10m
Work Description: veghlaci05 commented on code in PR #3172:
URL: https://github.com/apache/hive/pull/3172#discussion_r857385048
##########
ql/src/test/queries/clientpositive/acid_insert_overwrite_update.q:
##########
@@ -26,7 +26,6 @@ insert overwrite table sequential_update
values(current_timestamp, 0, current_ti
delete from sequential_update where seq=2;
select distinct IF(seq==0, 'LOOKS OKAY', 'BROKEN'),
regexp_extract(INPUT__FILE__NAME, '.*/(.*)/[^/]*', 1) from sequential_update;
-alter table sequential_update compact 'major';
Review Comment:
It turned out that the Q test running environment doesn't start the HMS
background threads at all. As a result the issued compactions are never
processed. From now on it is not possible to initiate a second compaction on
the same table with the same write id before the previous one is cleaned up. As
a result, the second compaction request was refused in this test. BTW this
questions the necessity of the compaction commands in these tests for me, but I
only removed only the second one to make the test green again.
Issue Time Tracking
-------------------
Worklog Id: (was: 761652)
Time Spent: 1h 10m (was: 1h)
> Worker shouldn't inject duplicate entries in `ready for cleaning` state into
> the compaction queue
> -------------------------------------------------------------------------------------------------
>
> Key: HIVE-26107
> URL: https://issues.apache.org/jira/browse/HIVE-26107
> Project: Hive
> Issue Type: Improvement
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> How to reproduce:
> 1) create an acid table and load some data ;
> 2) manually trigger the compaction for the table several times;
> 4) inspect compaction_queue: There are multiple entries in 'ready for
> cleaning' state for the same table.
>
> Expected behavior: All compaction request after the first one should be
> rejected until the table is changed again.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
