[ 
https://issues.apache.org/jira/browse/HIVE-26171?focusedWorklogId=761716&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761716
 ]

ASF GitHub Bot logged work on HIVE-26171:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Apr/22 11:26
            Start Date: 25/Apr/22 11:26
    Worklog Time Spent: 10m 
      Work Description: pvary commented on PR #3238:
URL: https://github.com/apache/hive/pull/3238#issuecomment-1108447729

   @zhangbutao: I think having a test would help preventing the situation when 
some change inadvertently reverts the fix. If writing a test is not 
prohibitively hard, I would suggest adding one, maybe with mocking the 
`DataConnectorProviderFactory` or something around that.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 761716)
    Time Spent: 20m  (was: 10m)

> HMSHandler get_all_tables method can not retrieve tables from remote database
> -----------------------------------------------------------------------------
>
>                 Key: HIVE-26171
>                 URL: https://issues.apache.org/jira/browse/HIVE-26171
>             Project: Hive
>          Issue Type: Bug
>          Components: Standalone Metastore
>    Affects Versions: 4.0.0-alpha-1, 4.0.0-alpha-2
>            Reporter: zhangbutao
>            Assignee: zhangbutao
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0-alpha-2
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> At present, get_all_tablesĀ  method in HMSHandler would not get table from 
> remote database. However, other component like presto and some jobs we 
> developed have used this api instead of _get_tables_ which could retrieve all 
> tables both native database and remote database .
> {code:java}
> // get_all_tables only can get tables from native database
> public List<String> get_all_tables(final String dbname) throws MetaException 
> {{code}
> {code:java}
> // get_tables can get tables from both native and remote database
> public List<String> get_tables(final String dbname, final String 
> pattern){code}
> I think we shoud fix get_all_tables to make it retrive tables from remote 
> database.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to