[ 
https://issues.apache.org/jira/browse/HIVE-26175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

renjianting updated HIVE-26175:
-------------------------------
    Description: 
A single quote in a comment causes parsing errors: such as 
{code:java}
select 1 -- I'm xxx
from tbl; {code}
Running a task like this will result in the following error:
{code:java}
NoViableAltException(377@[96:1: atomjoinSource : ( tableSource ( lateralView 
^)* | virtualTableSource ( lateralView ^)* | ( LPAREN ( KW_WITH | KW_SELECT | 
KW_MAP | KW_REDUCE | KW_FROM ) )=> subQuerySource ( lateralView ^)* | ( LPAREN 
LPAREN atomSelectStatement RPAREN setOperator )=> subQuerySource ( lateralView 
^)* | partitionedTableFunction ( lateralView ^)* | LPAREN ! joinSource RPAREN 
!);])                                         at 
org.antlr.runtime.DFA.noViableAlt(DFA.java:158)                                 
                                                            at 
org.antlr.runtime.DFA.predict(DFA.java:116)                                     
                                                            at 
org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.atomjoinSource(HiveParser_FromClauseParser.java:1593)
                           at 
org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.joinSource(HiveParser_FromClauseParser.java:1903)
                               at 
org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.fromSource(HiveParser_FromClauseParser.java:1527)
                               at 
org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.fromClause(HiveParser_FromClauseParser.java:1370)
                               at 
org.apache.hadoop.hive.ql.parse.HiveParser.fromClause(HiveParser.java:45322)    
                                                            at 
org.apache.hadoop.hive.ql.parse.HiveParser.atomSelectStatement(HiveParser.java:39792)
                                                       at 
org.apache.hadoop.hive.ql.parse.HiveParser.selectStatement(HiveParser.java:40044)
                                                           at 
org.apache.hadoop.hive.ql.parse.HiveParser.regularBody(HiveParser.java:39690)   
                                                            at 
org.apache.hadoop.hive.ql.parse.HiveParser.queryStatementExpressionBody(HiveParser.java:38900)
                                              at 
org.apache.hadoop.hive.ql.parse.HiveParser.queryStatementExpression(HiveParser.java:38788)
                                                  at 
org.apache.hadoop.hive.ql.parse.HiveParser.execStatement(HiveParser.java:2396)  
                                                            at 
org.apache.hadoop.hive.ql.parse.HiveParser.statement(HiveParser.java:1420)      
                                                            at 
org.apache.hadoop.hive.ql.parse.ParseDriver.parse(ParseDriver.java:220)         
                                                            at 
org.apache.hadoop.hive.ql.parse.ParseUtils.parse(ParseUtils.java:74)            
                                                            at 
org.apache.hadoop.hive.ql.parse.ParseUtils.parse(ParseUtils.java:67)            
                                                            at 
org.apache.hadoop.hive.ql.Driver.compile(Driver.java:616)                       
                                                            at 
org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1826)              
                                                            at 
org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1773)            
                                                            at 
org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1768)            
                                                            at 
org.apache.hadoop.hive.ql.reexec.ReExecDriver.compileAndRespond(ReExecDriver.java:126)
                                                      at 
org.apache.hadoop.hive.ql.reexec.ReExecDriver.run(ReExecDriver.java:214)        
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:239)        
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:188)             
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:402)            
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:335)            
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.processReader(CliDriver.java:471)          
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.processFile(CliDriver.java:487)            
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:793)          
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:759)                    
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:683)                   
                                                            at 
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)                     
                                                            at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)   
                                                            at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
                                                       at 
java.lang.reflect.Method.invoke(Method.java:498)                                
                                                            at 
org.apache.hadoop.util.RunJar.run(RunJar.java:323)                              
                                                            at 
org.apache.hadoop.util.RunJar.main(RunJar.java:236)                             
                                                    FAILED: ParseException line 
2:8 cannot recognize input near 'tbl' ';' '' in joinSource {code}

  was:
A single quote in a comment causes parsing errors: such as 
{code:java}
select 1 -- I'm xxx
from tbl; {code}
Running a task like this will result in the following error:
{code:java}
NoViableAltException(377@[201:64: ( ( KW_AS )? alias= identifier )?])           
                                                                       at 
org.antlr.runtime.DFA.noViableAlt(DFA.java:158)                                 
                                                            at 
org.antlr.runtime.DFA.predict(DFA.java:116)                                     
                                                            at 
org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.tableSource(HiveParser_FromClauseParser.java:4220)
                              at 
org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.atomjoinSource(HiveParser_FromClauseParser.java:1602)
                           at 
org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.joinSource(HiveParser_FromClauseParser.java:1903)
                               at 
org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.fromSource(HiveParser_FromClauseParser.java:1527)
                               at 
org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.fromClause(HiveParser_FromClauseParser.java:1370)
                               at 
org.apache.hadoop.hive.ql.parse.HiveParser.fromClause(HiveParser.java:45020)    
                                                            at 
org.apache.hadoop.hive.ql.parse.HiveParser.atomSelectStatement(HiveParser.java:39792)
                                                       at 
org.apache.hadoop.hive.ql.parse.HiveParser.selectStatement(HiveParser.java:40044)
                                                           at 
org.apache.hadoop.hive.ql.parse.HiveParser.regularBody(HiveParser.java:39690)   
                                                            at 
org.apache.hadoop.hive.ql.parse.HiveParser.queryStatementExpressionBody(HiveParser.java:38900)
                                              at 
org.apache.hadoop.hive.ql.parse.HiveParser.queryStatementExpression(HiveParser.java:38788)
                                                  at 
org.apache.hadoop.hive.ql.parse.HiveParser.execStatement(HiveParser.java:2396)  
                                                            at 
org.apache.hadoop.hive.ql.parse.HiveParser.statement(HiveParser.java:1420)      
                                                            at 
org.apache.hadoop.hive.ql.parse.ParseDriver.parse(ParseDriver.java:220)         
                                                            at 
org.apache.hadoop.hive.ql.parse.ParseUtils.parse(ParseUtils.java:74)            
                                                            at 
org.apache.hadoop.hive.ql.parse.ParseUtils.parse(ParseUtils.java:67)            
                                                            at 
org.apache.hadoop.hive.ql.Driver.compile(Driver.java:616)                       
                                                            at 
org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1826)              
                                                            at 
org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1773)            
                                                            at 
org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1768)            
                                                            at 
org.apache.hadoop.hive.ql.reexec.ReExecDriver.compileAndRespond(ReExecDriver.java:126)
                                                      at 
org.apache.hadoop.hive.ql.reexec.ReExecDriver.run(ReExecDriver.java:214)        
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:239)        
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:188)             
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:402)            
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:335)            
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.processReader(CliDriver.java:471)          
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.processFile(CliDriver.java:487)            
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:793)          
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:759)                    
                                                            at 
org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:683)                   
                                                            at 
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)                     
                                                            at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)   
                                                            at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
                                                       at 
java.lang.reflect.Method.invoke(Method.java:498)                                
                                                            at 
org.apache.hadoop.util.RunJar.run(RunJar.java:323)                              
                                                            at 
org.apache.hadoop.util.RunJar.main(RunJar.java:236)                             
                                                    FAILED: ParseException line 
2:21 cannot recognize input near ';' '' '' in table source {code}


> single quote in a comment causes parsing errors
> -----------------------------------------------
>
>                 Key: HIVE-26175
>                 URL: https://issues.apache.org/jira/browse/HIVE-26175
>             Project: Hive
>          Issue Type: Improvement
>          Components: CLI, Parser
>    Affects Versions: 3.1.3
>            Reporter: renjianting
>            Assignee: renjianting
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> A single quote in a comment causes parsing errors: such as 
> {code:java}
> select 1 -- I'm xxx
> from tbl; {code}
> Running a task like this will result in the following error:
> {code:java}
> NoViableAltException(377@[96:1: atomjoinSource : ( tableSource ( lateralView 
> ^)* | virtualTableSource ( lateralView ^)* | ( LPAREN ( KW_WITH | KW_SELECT | 
> KW_MAP | KW_REDUCE | KW_FROM ) )=> subQuerySource ( lateralView ^)* | ( 
> LPAREN LPAREN atomSelectStatement RPAREN setOperator )=> subQuerySource ( 
> lateralView ^)* | partitionedTableFunction ( lateralView ^)* | LPAREN ! 
> joinSource RPAREN !);])                                         at 
> org.antlr.runtime.DFA.noViableAlt(DFA.java:158)                               
>                                                               at 
> org.antlr.runtime.DFA.predict(DFA.java:116)                                   
>                                                               at 
> org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.atomjoinSource(HiveParser_FromClauseParser.java:1593)
>                            at 
> org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.joinSource(HiveParser_FromClauseParser.java:1903)
>                                at 
> org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.fromSource(HiveParser_FromClauseParser.java:1527)
>                                at 
> org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.fromClause(HiveParser_FromClauseParser.java:1370)
>                                at 
> org.apache.hadoop.hive.ql.parse.HiveParser.fromClause(HiveParser.java:45322)  
>                                                               at 
> org.apache.hadoop.hive.ql.parse.HiveParser.atomSelectStatement(HiveParser.java:39792)
>                                                        at 
> org.apache.hadoop.hive.ql.parse.HiveParser.selectStatement(HiveParser.java:40044)
>                                                            at 
> org.apache.hadoop.hive.ql.parse.HiveParser.regularBody(HiveParser.java:39690) 
>                                                               at 
> org.apache.hadoop.hive.ql.parse.HiveParser.queryStatementExpressionBody(HiveParser.java:38900)
>                                               at 
> org.apache.hadoop.hive.ql.parse.HiveParser.queryStatementExpression(HiveParser.java:38788)
>                                                   at 
> org.apache.hadoop.hive.ql.parse.HiveParser.execStatement(HiveParser.java:2396)
>                                                               at 
> org.apache.hadoop.hive.ql.parse.HiveParser.statement(HiveParser.java:1420)    
>                                                               at 
> org.apache.hadoop.hive.ql.parse.ParseDriver.parse(ParseDriver.java:220)       
>                                                               at 
> org.apache.hadoop.hive.ql.parse.ParseUtils.parse(ParseUtils.java:74)          
>                                                               at 
> org.apache.hadoop.hive.ql.parse.ParseUtils.parse(ParseUtils.java:67)          
>                                                               at 
> org.apache.hadoop.hive.ql.Driver.compile(Driver.java:616)                     
>                                                               at 
> org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1826)            
>                                                               at 
> org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1773)          
>                                                               at 
> org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1768)          
>                                                               at 
> org.apache.hadoop.hive.ql.reexec.ReExecDriver.compileAndRespond(ReExecDriver.java:126)
>                                                       at 
> org.apache.hadoop.hive.ql.reexec.ReExecDriver.run(ReExecDriver.java:214)      
>                                                               at 
> org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:239)      
>                                                               at 
> org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:188)           
>                                                               at 
> org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:402)          
>                                                               at 
> org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:335)          
>                                                               at 
> org.apache.hadoop.hive.cli.CliDriver.processReader(CliDriver.java:471)        
>                                                               at 
> org.apache.hadoop.hive.cli.CliDriver.processFile(CliDriver.java:487)          
>                                                               at 
> org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:793)        
>                                                               at 
> org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:759)                  
>                                                               at 
> org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:683)                 
>                                                               at 
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)                   
>                                                               at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
>                                                               at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>                                                        at 
> java.lang.reflect.Method.invoke(Method.java:498)                              
>                                                               at 
> org.apache.hadoop.util.RunJar.run(RunJar.java:323)                            
>                                                               at 
> org.apache.hadoop.util.RunJar.main(RunJar.java:236)                           
>                                                       FAILED: ParseException 
> line 2:8 cannot recognize input near 'tbl' ';' '' in joinSource {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to