[
https://issues.apache.org/jira/browse/HIVE-26183?focusedWorklogId=762955&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-762955
]
ASF GitHub Bot logged work on HIVE-26183:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/22 15:09
Start Date: 27/Apr/22 15:09
Worklog Time Spent: 10m
Work Description: pvary opened a new pull request, #3251:
URL: https://github.com/apache/hive/pull/3251
### What changes were proposed in this pull request?
- Refactor the HiveIcebergWriter-s to have a common interface
- Refactor the FilesForCommit to use Collections instead of Lists.
- Create a HiveIcebergBufferedDeleteWriter to collect the deleted row data
in memory and write it out sorted when the writer is closed
- Added tests for different Delete writers
### Why are the changes needed?
First step for implementing `UPDATE`s.
### Does this PR introduce _any_ user-facing change?
Not yet
### How was this patch tested?
Added unit tests
Issue Time Tracking
-------------------
Worklog Id: (was: 762955)
Remaining Estimate: 0h
Time Spent: 10m
> Create delete writer for the UPDATE statemens
> ---------------------------------------------
>
> Key: HIVE-26183
> URL: https://issues.apache.org/jira/browse/HIVE-26183
> Project: Hive
> Issue Type: Sub-task
> Reporter: Peter Vary
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> During the investigation of the updates of partitioned table we had the
> following issue:
> - Iceberg inserts are needed to be sorted by the new partition keys
> - Iceberg deletes are needed to be sorted by the old partition keys and
> filenames
> This could contradict each other. OTOH Hive updates create a single query and
> writes out the insert/delete record for ever row. This would mean plenty of
> open writers.
> We might want to create something like a
> https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/io/SortedPosDeleteWriter.java,
> but we do not want to keep the whole rows in memory.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
