[
https://issues.apache.org/jira/browse/HIVE-26107?focusedWorklogId=764168&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764168
]
ASF GitHub Bot logged work on HIVE-26107:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/22 11:18
Start Date: 29/Apr/22 11:18
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3172:
URL: https://github.com/apache/hive/pull/3172#discussion_r861711021
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -3705,12 +3707,22 @@ public CompactionResponse compact(CompactionRequest
rqst) throws MetaException {
long id = generateCompactionQueueId(stmt);
+ final ValidCompactorWriteIdList tblValidWriteIds =
TxnUtils.createValidCompactWriteIdList(
+ getValidWriteIds(new GetValidWriteIdsRequest(
Review Comment:
could we refactor this a bit, at least move GetValidWriteIdsRequest into a
separate declaration
Issue Time Tracking
-------------------
Worklog Id: (was: 764168)
Time Spent: 3h 40m (was: 3.5h)
> Worker shouldn't inject duplicate entries in `ready for cleaning` state into
> the compaction queue
> -------------------------------------------------------------------------------------------------
>
> Key: HIVE-26107
> URL: https://issues.apache.org/jira/browse/HIVE-26107
> Project: Hive
> Issue Type: Improvement
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> How to reproduce:
> 1) create an acid table and load some data ;
> 2) manually trigger the compaction for the table several times;
> 4) inspect compaction_queue: There are multiple entries in 'ready for
> cleaning' state for the same table.
>
> Expected behavior: All compaction request after the first one should be
> rejected until the table is changed again.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
