[
https://issues.apache.org/jira/browse/HIVE-26136?focusedWorklogId=766131&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-766131
]
ASF GitHub Bot logged work on HIVE-26136:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/22 16:21
Start Date: 04/May/22 16:21
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3204:
URL: https://github.com/apache/hive/pull/3204#discussion_r865029906
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergV2.java:
##########
@@ -310,6 +310,39 @@ public void testDeleteStatementWithOtherTable() {
HiveIcebergTestUtils.valueForRow(HiveIcebergStorageHandlerTestUtils.CUSTOMER_SCHEMA,
objects), 0);
}
+ @Test
+ public void testUpdateStatementUnpartitioned() {
+ Assume.assumeFalse("Iceberg UPDATEs are only implemented for
non-vectorized mode for now", isVectorized);
Review Comment:
Yeah, the read part is still unvectorized, as we need to handle the delete
files in a vectorized and effective way.
IIRC the Spark implementation was reading the delete files to a
`Roaring64Bitmap` and filtered them out after when the reading was done in a
vectorized way
Issue Time Tracking
-------------------
Worklog Id: (was: 766131)
Time Spent: 50m (was: 40m)
> Implement UPDATE statements for Iceberg tables
> ----------------------------------------------
>
> Key: HIVE-26136
> URL: https://issues.apache.org/jira/browse/HIVE-26136
> Project: Hive
> Issue Type: Task
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
